-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KV] Remove worker-
prefix from kv:namespace create when using wrangler in a pages project or without a name
property
#5007
Conversation
🦋 Changeset detectedLatest commit: 2caff1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-wrangler-5007 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5007/npm-package-wrangler-5007 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-wrangler-5007 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-create-cloudflare-5007 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-cloudflare-kv-asset-handler-5007 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-miniflare-5007 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-cloudflare-pages-shared-5007 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8114334808/npm-package-cloudflare-vitest-pool-workers-5007 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5007 +/- ##
==========================================
+ Coverage 70.32% 70.39% +0.06%
==========================================
Files 298 298
Lines 15542 15548 +6
Branches 3999 4002 +3
==========================================
+ Hits 10930 10945 +15
+ Misses 4612 4603 -9
|
worker-
prefix from kv:namespace create when using wrangler in a pages project or without a name
property
0ada459
to
099a342
Compare
Rebased and added to the V4 milestone. |
…e` command Previously, if there was no Worker defined by a local `wrangler.toml` or that Worker had no `name` property then any KV namespace that was created by Wrangler would use `worker_` as a prefix, rather than the Worker's name. This is a minor breaking change to the name given to a newly created KV namespace, which is unlikely to affect many, if any, developers.
099a342
to
2caff1c
Compare
Merging to the v4 branch. |
…e` command (#5007) Previously, if there was no Worker defined by a local `wrangler.toml` or that Worker had no `name` property then any KV namespace that was created by Wrangler would use `worker_` as a prefix, rather than the Worker's name. This is a minor breaking change to the name given to a newly created KV namespace, which is unlikely to affect many, if any, developers.
…e` command (#5007) Previously, if there was no Worker defined by a local `wrangler.toml` or that Worker had no `name` property then any KV namespace that was created by Wrangler would use `worker_` as a prefix, rather than the Worker's name. This is a minor breaking change to the name given to a newly created KV namespace, which is unlikely to affect many, if any, developers.
…e` command (#5007) Previously, if there was no Worker defined by a local `wrangler.toml` or that Worker had no `name` property then any KV namespace that was created by Wrangler would use `worker_` as a prefix, rather than the Worker's name. This is a minor breaking change to the name given to a newly created KV namespace, which is unlikely to affect many, if any, developers.
Fixes #
What this PR solves / how to test: Currently the kv:namespace create command differs from other
create
commands where it prefixes the input withworker-
when using the command in e.g. a pages project without awrangler.toml
or with awrangler.toml
but without aname
property. This is a regression to how the dashboard and other products works and can cause confusion for developers.Author has addressed the following: This has been broken into two separate PRs to focus on two different topics, see #5050 for the original change.