-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention env var when using API Token and whoami
/log(out|in)
commands
#4925
Mention env var when using API Token and whoami
/log(out|in)
commands
#4925
Conversation
🦋 Changeset detectedLatest commit: a4420a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-wrangler-4925 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4925/npm-package-wrangler-4925 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-wrangler-4925 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-create-cloudflare-4925 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-cloudflare-kv-asset-handler-4925 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-miniflare-4925 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-cloudflare-pages-shared-4925 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9876830267/npm-package-cloudflare-vitest-pool-workers-4925 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
99c9ba5
to
86af1b5
Compare
whoami
/logout
commandswhoami
/log(out|in)
commands
86af1b5
to
66285aa
Compare
Hey @dom96 - thanks for improving this DX.
|
66285aa
to
72f9e43
Compare
@petebacondarwin thanks for the tips! I updated the snapshots whose updates seemed to make sense, but I did get a bunch of other updated snapshots that looked wrong (I also saw many test failures, from previous PRs it didn't seem to be to do with my changes, so I'm unsure whether I should dive deeper yet) |
Let's see how the CI pans out. I can look into any random failures. |
72f9e43
to
b4f81e3
Compare
989cc77
to
0619717
Compare
|
||
" | ||
`); | ||
expect(std.warn).toMatchInlineSnapshot(`""`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs fixing...
0619717
to
e5f6831
Compare
This test hits a public database that has started failing with > too many connections for role 'reader' We need to find an alternative (ideally local) DB to test against.
e5f6831
to
a4420a3
Compare
Thank you for the help in getting this merged in! |
I ran into this while trying to log in to my other account. Didn't realise wrangler uses this env var, so was confused why I couldn't logout.
What this PR solves / how to test:
Author has addressed the following: