-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 chore: move links to old templates repo to point here #3099
Conversation
|
@RamIdeas In regards to some work your doing, maybe we should discuss this internally. |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-wrangler-3099 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3099/npm-package-wrangler-3099 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-wrangler-3099 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-create-cloudflare-3099 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-cloudflare-kv-asset-handler-3099 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-miniflare-3099 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-cloudflare-pages-shared-3099 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-cloudflare-vitest-pool-workers-3099 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3099 +/- ##
==========================================
+ Coverage 70.31% 70.38% +0.06%
==========================================
Files 298 298
Lines 15551 15551
Branches 4001 4001
==========================================
+ Hits 10935 10945 +10
+ Misses 4616 4606 -10 |
49fd1dd
to
f722c72
Compare
- validated new template dirs - including those that moved into experimental - fixed at least one tyop
f722c72
to
86ef019
Compare
Fixes #2533.
I'm new to this project, so please advise if I've missed anything. Don't think it needs a changeset.
What this PR solves / how to test:
Find references to legacy https://github.com/cloudflare/templates and replace with appropriate link under https://github.com/cloudflare/workers-sdk.
Validated new links, including some templates that moved to experimental/ subdir.
Also found a fixed at least one tyop.
Fixed corresponding tests and tested.
Now the badge will load the newer/proper template!
Author has included the following, where applicable:
Reviewer has performed the following, where applicable: