Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 chore: move links to old templates repo to point here #3099

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

dotysan
Copy link
Contributor

@dotysan dotysan commented Apr 27, 2023

Fixes #2533.

I'm new to this project, so please advise if I've missed anything. Don't think it needs a changeset.

What this PR solves / how to test:

Find references to legacy https://github.com/cloudflare/templates and replace with appropriate link under https://github.com/cloudflare/workers-sdk.

Validated new links, including some templates that moved to experimental/ subdir.

Also found a fixed at least one tyop.

Fixed corresponding tests and tested.

Now the Deploy with Workers badge will load the newer/proper template!

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@dotysan dotysan requested a review from a team as a code owner April 27, 2023 16:52
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: 86ef019

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dotysan dotysan changed the title chore: move links to old templates repo to point here 🧹 chore: move links to old templates repo to point here Apr 27, 2023
@JacobMGEvans JacobMGEvans added blocked Blocked on other work templates Issue with a workers-sdk template labels May 5, 2023
@JacobMGEvans JacobMGEvans self-assigned this May 5, 2023
@JacobMGEvans
Copy link
Contributor

@RamIdeas In regards to some work your doing, maybe we should discuss this internally.

@JacobMGEvans JacobMGEvans added the internal Requires support from the Cloudflare Platform label May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-wrangler-3099

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3099/npm-package-wrangler-3099

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-wrangler-3099 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-create-cloudflare-3099 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-cloudflare-kv-asset-handler-3099
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-miniflare-3099
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-cloudflare-pages-shared-3099
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8163292429/npm-package-cloudflare-vitest-pool-workers-3099

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.31.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.1
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (b53e0bd) to head (86ef019).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
+ Coverage   70.31%   70.38%   +0.06%     
==========================================
  Files         298      298              
  Lines       15551    15551              
  Branches     4001     4001              
==========================================
+ Hits        10935    10945      +10     
+ Misses       4616     4606      -10     

see 7 files with indirect coverage changes

@jspspike jspspike removed the blocked Blocked on other work label Aug 14, 2023
@lrapoport-cf lrapoport-cf assigned lrapoport-cf and unassigned RamIdeas Feb 7, 2024
@lrapoport-cf lrapoport-cf removed the internal Requires support from the Cloudflare Platform label Feb 7, 2024
@mrbbot mrbbot added the awaiting Cloudflare response Awaiting response from workers-sdk maintainer team label Feb 7, 2024
templates/worker-d1-api/README.md Outdated Show resolved Hide resolved
dotysan and others added 5 commits March 5, 2024 21:32
@petebacondarwin petebacondarwin merged commit bb3db47 into cloudflare:main Mar 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting Cloudflare response Awaiting response from workers-sdk maintainer team templates Issue with a workers-sdk template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹 [chore] Template Migration
9 participants