Skip to content

Commit

Permalink
Removed stale comment
Browse files Browse the repository at this point in the history
  • Loading branch information
pmiguel committed Feb 28, 2024
1 parent f55f6cf commit fb991c7
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 15 deletions.
12 changes: 1 addition & 11 deletions packages/wrangler/src/__tests__/queues.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { rest } from "msw";
import { mockAccountId, mockApiToken } from "./helpers/mock-account-id";
import { mockConsoleMethods } from "./helpers/mock-console";
import { clearDialogs } from "./helpers/mock-dialogs";
import { useMockIsTTY } from "./helpers/mock-istty";
import { msw } from "./helpers/msw";
import { runInTempDir } from "./helpers/run-in-tmp";
import { runWrangler } from "./helpers/run-wrangler";
Expand All @@ -14,14 +12,6 @@ describe("wrangler", () => {
runInTempDir();
const std = mockConsoleMethods();

const { setIsTTY } = useMockIsTTY();
beforeEach(() => {
setIsTTY(true);
});
afterEach(() => {
clearDialogs();
});

describe("queues", () => {
it("should show the correct help text", async () => {
await runWrangler("queues --help");
Expand Down Expand Up @@ -278,7 +268,7 @@ describe("wrangler", () => {
`);
});

it("should send send queue settings with delivery delay", async () => {
it("should send queue settings with delivery delay", async () => {
const requests = mockCreateRequest("testQueue", { delivery_delay: 10 });
await runWrangler("queues create testQueue --delivery-delay=10");
expect(std.out).toMatchInlineSnapshot(`
Expand Down
2 changes: 0 additions & 2 deletions packages/wrangler/src/queues/cli/commands/consumer/add.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ function createBody(
dead_letter_queue: args.deadLetterQueue,
};

// Workaround, Yargs does not play nicely with both --parameter and --no-parameter set.
// Negating a number parameter returns 0, making retryDelay an array with [0, <value>]
if (Array.isArray(args.retryDelay)) {
throw new CommandLineArgsError(
`Error: can't use more than a delay setting.`
Expand Down
2 changes: 0 additions & 2 deletions packages/wrangler/src/queues/cli/commands/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ function createBody(
queue_name: args.name,
};

// Workaround, Yargs does not play nicely with both --parameter and --no-parameter set.
// Negating a number parameter returns 0, making deliveryDelay an array with [0, <value>]
if (Array.isArray(args.deliveryDelay)) {
throw new CommandLineArgsError(
`Error: can't use more than a delay setting.`
Expand Down

0 comments on commit fb991c7

Please sign in to comment.