Exclude standardPricingWarning from dryrun (#4880)

* Exclude standardPricingWarning from dryrun That way we do not need authentication for dryrun, again. * fixup! Exclude standardPricingWarning from dryrun * fixup! Exclude standardPricingWarning from dryrun --------- Co-authored-by: petero-dk <2478689+petero-dk@users.noreply.github.com>
cloudflare · Jan 31, 2024 · 65da40a · 65da40a
1 parent 7a34194
commit 65da40a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/twelve-coins-hear.md b/.changeset/twelve-coins-hear.md
@@ -0,0 +1,10 @@
+---
+"wrangler": patch
+---
+
+fix: do not attempt login during dry-run
+
+The "standard pricing" warning was attempting to make an API call that was causing a login attempt even when on a dry-run.
+Now this warning is disabled during dry-runs.
+
+Fixes #4723
diff --git a/packages/wrangler/src/deploy/index.ts b/packages/wrangler/src/deploy/index.ts
@@ -293,7 +293,9 @@ export async function deployHandler(
 					args.siteInclude,
 					args.siteExclude
 			  );
-	await standardPricingWarning(accountId, config);
+
+	if (!args.dryRun) await standardPricingWarning(accountId, config);
+
 	await deploy({
 		config,
 		accountId,