Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERFSCALE-1848 AWS Windows workers enablement #200

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

afcollins
Copy link
Member

Description

Enables the install-time (Day0) and post-install (Day2) configuration requirements to deploy windows workers.

Day0 runs separate openshift-install create manifests in order to copy the Network with hybridOverlayConfig configured.

Day2 installs the operators and other resources required for Windows Machine Config Operator (WMCO).

Follows the procedure outlined in the documentation for the WMCO: https://docs.openshift.com/container-platform/4.11/windows_containers/enabling-windows-container-workloads.html.

Fixes

@@ -0,0 +1,110 @@
---
#
# Applies Windows Worker nodes configuration to a cluster post installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented aspects of the yaml

@@ -0,0 +1,5 @@
openshift_toggle_windows_node: false
openshift_wmco_image: "quay.io/winc/wmco-index:6.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should template this out, but default to this value or maybe the :lateset

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall g2g just some personal nits...

Comment on lines +24 to +38
- name: winC - Create WMCO catalog source
kubernetes.core.k8s:
kubeconfig: "{{ kubeconfig_path }}"
name: openshift-windows-machine-config-operator
template: catalogsource.yaml.j2
retries: 3

- name: winC - Wait for catalog source
shell: oc get catalogsource wmco -o=jsonpath={.status.connectionState.lastObservedState} -n openshift-marketplace
environment:
KUBECONFIG: "{{ kubeconfig_path }}"
register: result
until: result.stdout == "READY"
retries: 3
delay: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why do you have to create a catalogsource?, these steps are not part of https://docs.openshift.com/container-platform/4.11/windows_containers/enabling-windows-container-workloads.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I do need to remove it. Learned that from the winc team yesterday.

@jtaleric
Copy link
Member

Is this PR still relevant @afcollins ?

@afcollins
Copy link
Member Author

Yes, it is still required for testing windows workers. That work was put on hold last year. Last I checked, the WMCO changed, so this has to be re-tested to ensure it works and close out all associated PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants