Add an ilab API on top of the Crucible service layer
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
pushed a commit
to dbutenhof/cpt-dashboard
that referenced
this pull request
Oct 17, 2024
This relies on the ilab API in cloud-bulldozer#123, which in turn builds on the crucible service in cloud-bulldozer#122.
7 tasks
dbutenhof
pushed a commit
to dbutenhof/cpt-dashboard
that referenced
this pull request
Oct 17, 2024
This relies on the ilab API in cloud-bulldozer#123, which in turn builds on the crucible service in cloud-bulldozer#122.
This encapsulates substantial logic to encapsulate interpretation of the Crucible Common Data Model OpenSearch schema for the use of CPT dashboard API components. By itself, it does nothing.
dbutenhof
pushed a commit
to dbutenhof/cpt-dashboard
that referenced
this pull request
Oct 18, 2024
This relies on the ilab API in cloud-bulldozer#123, which in turn builds on the crucible service in cloud-bulldozer#122.
7 tasks
dbutenhof
added a commit
to dbutenhof/cpt-dashboard
that referenced
this pull request
Oct 24, 2024
This adds the basic UI to support comparison of the metrics of two InstructLab runs. This compares only the primary metrics of the two runs, in a relative timeline graph. This is backed by cloud-bulldozer#125, which is backed by cloud-bulldozer#124, which is backed by cloud-bulldozer#123, which is backed by cloud-bulldozer#122. These represent a series of steps towards a complete InstructLab UI and API, and will be reviewed and merged from cloud-bulldozer#122 forward.
dbutenhof
pushed a commit
to dbutenhof/cpt-dashboard
that referenced
this pull request
Oct 24, 2024
This adds the basic UI to support comparison of the metrics of two InstructLab runs. This compares only the primary metrics of the two runs, in a relative timeline graph. This is backed by cloud-bulldozer#125, which is backed by cloud-bulldozer#124, which is backed by cloud-bulldozer#123, which is backed by cloud-bulldozer#122. These represent a series of steps towards a complete InstructLab UI and API, and will be reviewed and merged from cloud-bulldozer#122 forward.
7 tasks
This was referenced Nov 6, 2024
7 tasks
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This was referenced Nov 18, 2024
This uses `black`, `isort` and `flake8` to check code quality, although failure is ignored until we've cleaned it up (which has begin in PR cloud-bulldozer#139 against the `revamp` branch). Minimal unit testing is introduced, generating a code coverage report. The text summary is added to the Action summary page, and the more detailed HTML report is stored as an artifact for download. NOTE: The GitHub Action environment is unhappy with `uvicorn` 0.15; upgrading to the latest 0.32.x seems to work and hasn't obviously broken anything else.
This is a draft to archive what I've done before I evaporate for the rest of 2024, because, you know, I could get run over by a reindeer or something... This brings crucible service test coverage to 50%.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
`crucible_svc.py` test coverage is now at 96%. While the remaining 4% is worth some effort later, subsequent ILAB PRs will change some of this code anyway and will require test adjustments so it's good enough for now.
7 tasks
Coverage is up to 97%, and I think I'm stopping there ...
This builds on the `crucible_svc` layer in cloud-bulldozer#122 to add a backend API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Provide the
api/v1/ilabAPI endpoint to allow a client to query collected data on a Crucible CDM OpenSearch instance through thecrucible_svcservice layer. It is backed by the Crucible layer in #122, so only the final commit represents changes in this PR.Related Tickets & Documents
Various Jira stories under Epic PANDA-496.
Checklist before requesting a review
Testing
Manual testing using the RHEL AI InstructLab RDU3 Crucible data source, via
curlagainst a local CPT backend server instance. E.g.,