-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #6109
base: master
Are you sure you want to change the base?
Update README.md #6109
Conversation
* If there already is an open issue you could comment on it to add precisions about the problem or confirm it | ||
* In case there isn't, you can open a new issue with an explicit title and as much information as possible (OS, Clementine version, how to reproduce the problem...) | ||
* If there is already an open issue you could comment on it to add precisions about the problem or confirm on it | ||
* In case there isn't, you can open a new issue with an explicit title with as much information as possible (OS, Clementine version, how to reproduce the problem...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that
with an explicit title with as much information as possible
is better than
with an explicit title and as much information as possible
? It changes meaning and advises to put all possible information in the title, it is rarely possible
Also, why "confirm on it" is better than "confirm it"?
Disclaimer: not a native speaker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely agreeing that the title doesn't have to contain as much information as possible (it really shouldn't), and "with" clearly associates the clause with "title" not with "issue".
"Confirm on it" would basically mean "signing a document, confirming that what is stated in the document is true". That's not what was intended here.
That leaves us with the "already is" vs "is already" change… not a strong preference for either.
update please @JeffChuaZiLe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the first change (if there is already), but the other changes seem to make the sentence more awkward.
* If there already is an open issue you could comment on it to add precisions about the problem or confirm it | ||
* In case there isn't, you can open a new issue with an explicit title and as much information as possible (OS, Clementine version, how to reproduce the problem...) | ||
* If there is already an open issue you could comment on it to add precisions about the problem or confirm on it | ||
* In case there isn't, you can open a new issue with an explicit title with as much information as possible (OS, Clementine version, how to reproduce the problem...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely agreeing that the title doesn't have to contain as much information as possible (it really shouldn't), and "with" clearly associates the clause with "title" not with "issue".
"Confirm on it" would basically mean "signing a document, confirming that what is stated in the document is true". That's not what was intended here.
That leaves us with the "already is" vs "is already" change… not a strong preference for either.
Correct grammar errors for README.md.