ASX,WPL Parsers: Implement no-metadata playlist saving.

clementine-player · Mar 16, 2022 · 1eec3aa · 1eec3aa
1 parent 4de215c
commit 1eec3aa
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/playlistparsers/asxparser.cpp b/src/playlistparsers/asxparser.cpp
@@ -120,6 +120,11 @@ Song ASXParser::ParseTrack(QXmlStreamReader* reader, const QDir& dir) const {
 
 void ASXParser::Save(const SongList& songs, QIODevice* device, const QDir&,
                      Playlist::Path path_type) const {
+  QSettings s;
+  s.beginGroup(Playlist::kSettingsGroup);
+  bool writeMetadata = s.value(Playlist::kWriteMetadata, true).toBool();
+  s.endGroup();
+
   QXmlStreamWriter writer(device);
   writer.setAutoFormatting(true);
   writer.setAutoFormattingIndent(2);
@@ -129,12 +134,14 @@ void ASXParser::Save(const SongList& songs, QIODevice* device, const QDir&,
     writer.writeAttribute("version", "3.0");
     for (const Song& song : songs) {
       StreamElement entry("entry", &writer);
-      writer.writeTextElement("title", song.title());
+      if (!song.title().isEmpty() && writeMetadata) {
+        writer.writeTextElement("title", song.title());
+      }
       {
         StreamElement ref("ref", &writer);
         writer.writeAttribute("href", song.url().toString());
       }
-      if (!song.artist().isEmpty()) {
+      if (!song.artist().isEmpty() && writeMetadata) {
         writer.writeTextElement("author", song.artist());
       }
     }

diff --git a/src/playlistparsers/wplparser.cpp b/src/playlistparsers/wplparser.cpp
@@ -79,14 +79,19 @@ void WplParser::ParseSeq(const QDir& dir, QXmlStreamReader* reader,
 
 void WplParser::Save(const SongList& songs, QIODevice* device, const QDir& dir,
                      Playlist::Path path_type) const {
+  QSettings s;
+  s.beginGroup(Playlist::kSettingsGroup);
+  bool writeMetadata = s.value(Playlist::kWriteMetadata, true).toBool();
+  s.endGroup();
+
   QXmlStreamWriter writer(device);
   writer.setAutoFormatting(true);
   writer.setAutoFormattingIndent(2);
   writer.writeProcessingInstruction("wpl", "version=\"1.0\"");
 
   StreamElement smil("smil", &writer);
 
-  {
+  if (writeMetadata) {
     StreamElement head("head", &writer);
     WriteMeta("Generator", "Clementine -- " CLEMENTINE_VERSION_DISPLAY,
               &writer);