-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min php version to 8.0 #31765
Open
colemanw
wants to merge
1
commit into
civicrm:master
Choose a base branch
from
colemanw:php8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump min php version to 8.0 #31765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
This was referenced Jan 12, 2025
Well mine updates composer.lock |
This required a minor version bump to typo3/phar-stream-wrapper, which seems fine
@totten I think this is ready to go. Only failing tests are the ones from infra running php 7.4. I think all we need to do is bump that up. |
yeh and the WP / Drupal tests won't be fixed until we merge the relevant PRs in their repos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With the major version bump to Civi 6.0, let's also bump the dependencies.
PHP 7.4 has been EOL since 2022, time to drop it.
Technical Details
Note that existing sites that use php 7.4 won't immediately stop working, rather a system check will alert them "To ensure the continued operation of CiviCRM, upgrade your server now."
This required a minor version bump to typo3/phar-stream-wrapper, which seems fine.