Partial fix for broken tokens in event confirmation email #31723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See https://lab.civicrm.org/dev/core/-/issues/5676.
Before
The email confirmation text gets curly braces within URLs converted to URL encoding, breaking tokens. This happens on a) the Manage Event » Online Registration tab, b) the Register Participant page, and c) the email itself.
After
a) and b) are fixed, because we can override
getFieldsToExcludeFromPurification()
. However, the email itself is purified inCivi\WorkflowMessage\GenericWorkflowMessage::getUserEnteredHTML()
, which has no such bypass.Comments
Given that this was the very field that let to
getPurifiedDefaults()
in the first place, I'm not sure we should be bypassing purification.In fact, it seems like there's a potential security issue here if purification happens before the tokens are rendered.