dev/core#5610 Simplifying the session cookie message to make it more readable

[shaneonabike]

Overview

When a session key expires or does exist the error that appears is pretty intense and less than clear for clients even though it clearly states what the issue is.

Example use-case

1. Go to a Contribution page
2. Fill out the details and click on Confirm
3. Leave it for a while (maybe a day -- depending on your CMS cookie settings)
4. Receive error message

Current behaviour

We receive the error message

Proposed behaviour

Perhaps we can modify this just to be simpler. If we want to give the tips about Site Administrators this could be pushed the log files or displayed internally? I see the following scenarios

• Invalid Cookie (so we find a cookie but it's no good): Sorry, your session cookie is no longer valid so for your safety you must reload the page and try again. and then in smaller text Error Type: Could not find valid session key.
• No Cookie (we check and no cookie exists at all): Sorry, this page requires cookies to be enabled in your browser settings. and then in smaller text Error Type: Cookie was not discovered.

Comments

Is there other scenarios that we could capture like if it's a subdomain but the session key isn't valid because of the configuration?

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5610

[ufundo]

One of those messages I've seen so many times I don't notice it any more, but when you stop and look at it, it's nasty... and imagine it's pretty off putting to your average user.

So I think this is a big improvement

Thanks @shaneonabike

[colemanw]

I agree with this change. One nitpick: several of the translated strings are almost the same but not exactly the same. This creates more work for translators (if they were exactly the same, it would only require translating once).

[shaneonabike]

Totally fair @colemanw. I changed two of them to match Sorry, your session has expired. Please reload the page or go back and try again.

I left the other one because it was more inline with the messaging that was there before pertaining to resubmitting the information, because when that is triggered it apparently returns the user to the page (but I honestly have no idea). If you want that to be the same I'm ok with that too.