Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index check for bytevector-reference functions #822

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix index check for bytevector-reference functions #822

merged 1 commit into from
Mar 26, 2024

Conversation

mflatt
Copy link
Contributor

@mflatt mflatt commented Mar 25, 2024

Intended as a repair for #821.

burgerrg
burgerrg reviewed Mar 25, 2024
View reviewed changes
s/prims.ss Outdated Show resolved Hide resolved
@mflatt
Copy link
Contributor Author

mflatt commented Mar 25, 2024

Looks like I need to adjust tests so that error tests produce output independent of the word size.

@burgerrg
Copy link
Contributor

Using any positive size less than 4 should do the trick.

burgerrg
burgerrg approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@burgerrg burgerrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@mflatt mflatt merged commit 3555ad0 into cisco:main Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgerrg burgerrg burgerrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mflatt @burgerrg