Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 10.0.0 #801

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Version 10.0.0 #801

merged 1 commit into from
Feb 6, 2024

Conversation

burgerrg
Copy link
Contributor

@burgerrg burgerrg commented Feb 1, 2024

  • (scheme-version) now includes the patch version number even when it's 0.
  • make install now includes the patch version in the directory name even when it's 0.
  • All 9.9.9 instances in the release notes are now 10.0.0.
  • The Windows install no longer includes the Microsoft Visual C++ redistributable merge modules. This change was made in Version 9.6.0 but didn't get ported into the Version 10 branch until now.

@burgerrg burgerrg force-pushed the version-10 branch 2 times, most recently from e183526 to 29a6b01 Compare February 1, 2024 21:16
@burgerrg burgerrg requested a review from mflatt February 1, 2024 21:22
@mflatt
Copy link
Contributor

mflatt commented Feb 1, 2024

Thanks for the repair to (scheme-version). The original intent was to follow Semantic Versioning, and I think I probably got confused started mixing up conventions by dropping a 0 as the patch number.

The makefiles/install.zuo scripts still drops a 0 as the patch number when building an install directory name. For example, boot files are installed by default into /usr/local/lib/csv10.0/. Should that change, too, to make it /usr/local/lib/csv10.0.0/? I think the right change would be at line 73:

  (define Version (let ([l (get-version)])
                    (~a "csv" (list-ref l 0) "." (list-ref l 1) "." (list-ref l 2)
                        (if (= (list-ref l 3) 0)
                            ""
                            (~a "-pre-release." (list-ref l 3))))))

@burgerrg burgerrg force-pushed the version-10 branch 2 times, most recently from a62af69 to fd13833 Compare February 1, 2024 21:59
@burgerrg burgerrg force-pushed the version-10 branch 2 times, most recently from 51e8025 to 4b130df Compare February 5, 2024 18:39
@burgerrg burgerrg merged commit 253230f into main Feb 6, 2024
39 checks passed
@burgerrg burgerrg deleted the version-10 branch February 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants