fix re-rendering when no parameters have changed (#68)

chrisrzhou · Oct 16, 2020 · 9ccdbbf · 9ccdbbf
1 parent 80fca9b
commit 9ccdbbf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/index.js b/src/index.js
@@ -35,9 +35,6 @@ function ReactWordCloud({
   words,
   ...rest
 }) {
-  const mergedCallbacks = { ...defaultCallbacks, ...callbacks };
-  const mergedOptions = { ...defaultOptions, ...options };
-
   const [ref, selection, size] = useResponsiveSvgSelection(
     minSize,
     initialSize,
@@ -48,6 +45,9 @@ function ReactWordCloud({
 
   useEffect(() => {
     if (selection) {
+      const mergedCallbacks = { ...defaultCallbacks, ...callbacks };
+      const mergedOptions = { ...defaultOptions, ...options };
+
       render.current({
         callbacks: mergedCallbacks,
         maxWords,
@@ -57,7 +57,7 @@ function ReactWordCloud({
         words,
       });
     }
-  }, [maxWords, mergedCallbacks, mergedOptions, selection, size, words]);
+  }, [maxWords, callbacks, options, selection, size, words]);
 
   return <div ref={ref} style={{ height: '100%', width: '100%' }} {...rest} />;
 }