Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hebrew translation #655

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Update Hebrew translation #655

merged 4 commits into from
Jan 10, 2025

Conversation

tzagim
Copy link
Contributor

@tzagim tzagim commented Jan 8, 2025

Thank you very much for the great app

@chenxiaolong
Copy link
Owner

Thanks for the PR! It looks like the build failed because pref_header_rules shows up twice in the file:

> /home/runner/work/BCR/BCR/app/src/main/res/values-iw/strings.xml: Error: Found item String/pref_header_rules more than one time

@tzagim
Copy link
Contributor Author

tzagim commented Jan 8, 2025

Thanks for the PR! It looks like the build failed because pref_header_rules shows up twice in the file:

> /home/runner/work/BCR/BCR/app/src/main/res/values-iw/strings.xml: Error: Found item String/pref_header_rules more than one time

Oops, Done

@chenxiaolong
Copy link
Owner

Thanks! Looks like a couple more changes are needed:

  • notification_channel_persistent_desc is also duplicated
  • Android requires pref_min_duration_desc to have one, two, and other for Hebrew (currently missing two)

@tzagim
Copy link
Contributor Author

tzagim commented Jan 9, 2025

I removed the duplicate lines, grouped the lines by topic to avoid future confusion.
Hope it's ok now.

Copy link
Owner

@chenxiaolong chenxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@chenxiaolong chenxiaolong merged commit 776c1a8 into chenxiaolong:master Jan 10, 2025
1 check passed
chenxiaolong added a commit that referenced this pull request Jan 10, 2025
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants