Bugfix: span gaps over null values beyond scale limits #11984
Merged
+110
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this configuration
produces
Bug: The line is not spanned over to the points
[0, 3]
and[50, 1.5]
despitespanGaps
beingtrue
. This happens when the first point beyondx min
orx max
limits contains anull
value ([10, null]
and[40, null]
).This PR contains changes in
_getStartAndCountOfVisiblePoints
inhelpers.extras.ts
fixing the error. It also contains 3 new tests incontroller.line.tests.js
.Now the above configuration results in:
Issues fixed: