(v2) fix: restore lipgloss.Color behavior #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
changed the title
The new behavior of `lipgloss.Color` taking `any` type is ambiguous and can lead to unexpected results. This commit restores the original behavior of `lipgloss.Color` taking a hex string or an int string, and returning a color.Color. To use a 4-bit color, use `lipgloss.Red`, `lipgloss.Blue`, etc. To use a 16-bit color, use `lipgloss.ANSIColor`. To use a 24-bit color, use `lipgloss.Color`, `lipgloss.RGBColor`, or any other `color.Color` value.
aymanbagabas
force-pushed
the
v2-colors
branch
from
9450adb to
7d7667f
Compare
meowgorithm
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new behavior of
lipgloss.Colortakinganytype is ambiguous and can lead to unexpected results. This commit restores the original behavior oflipgloss.Colortaking a hex string or an int string, and returning a color.Color.To use a 4-bit color, use
lipgloss.Red,lipgloss.Blue, etc. To use a 16-bit color, uselipgloss.ANSIColor. To use a 24-bit color, uselipgloss.Color,lipgloss.RGBColor, or any othercolor.Colorvalue.Fixes: #437