Wrangle nat #192
Merged
Wrangle nat #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/dfm/projects/data_processing/nat/convert_nat_to_dolma_format.py
Outdated
Show resolved
Hide resolved
src/dfm/projects/data_processing/nat/convert_nat_to_dolma_format.py
Outdated
Show resolved
Hide resolved
src/dfm/projects/data_processing/nat/convert_nat_to_dolma_format.py
Outdated
Show resolved
Hide resolved
src/dfm/projects/data_processing/nat/convert_nat_to_dolma_format.py
Outdated
Show resolved
Hide resolved
KennethEnevoldsen
approved these changes
Nov 22, 2023
|
seems like linting fails but otherwise it looks good |
|
Ah, polars was not in the dependencies. I've added it to the main dependencies in pyproject.toml. Is that fine or would you prefer it as optional? |
|
it is fine in the main ones |
|
This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrangle NAT to the standard format. Any comments/things I missed before running, @KennethEnevoldsen? :)