Vulkan: Improve post-shutdown cleanup and minor improvements #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix validation error introduced in 1706075 Make renderpass discard previous image content and clear during renderpass instead of before
Possible performance improvement? Knowing that
goeiecool9999
force-pushed
the
vulkanfixesandcleanup
branch
from
5ae6a4d to
e524e08
Compare
goeiecool9999
force-pushed
the
vulkanfixesandcleanup
branch
from
b784c32 to
44a3c00
Compare
fixes a bug where one iteration is not enough due to dependency chains.
goeiecool9999
force-pushed
the
vulkanfixesandcleanup
branch
from
1c61cca to
0866c47
Compare
|
FYI I replicated some of your changes in b53b223 in regards to |
# Conflicts: # src/Cafe/HW/Latte/Renderer/RendererOuputShader.cpp # src/Cafe/HW/Latte/Renderer/Vulkan/VulkanRendererCore.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR it is possible to use the debug "Stop emulation" button or close cemu without the validation layer complaining about resources that haven't been cleaned up.
It also fixes some other minor validation errors
It also changes the flags for BeginCommandBuffer from VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT to VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT. Cemu only submits every recorded command buffer once and this might allow drivers to manage them more efficiently.