fix: Correct branch name extraction in CI workflow #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeVikingMark
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Jan 6, 2025
| @@ -37,7 +37,7 @@ jobs: | |||
| - name: Trim branch name | |||
| id: trim_ref | |||
| run: | | |||
| echo "branch=$(${${{ github.ref }}:11})" >> $GITHUB_OUTPUT | |||
| echo "branch=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
TBH looks like this variable isn't used at all. Same for debug below.
Am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the branch name extraction in the CI workflow by:
$(${${{ github.ref }}:11})with proper GitHub Actions syntaxGITHUB_REFwith proper parameter expansionrefs/*/patternThis change ensures proper branch name extraction for all GitHub event triggers.