Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump github.com/prometheus/client_golang from 1.18.0 to 1.19.1 #3397

Closed
wants to merge 4 commits into from
Closed

chore(deps): Bump github.com/prometheus/client_golang from 1.18.0 to 1.19.1 #3397

wants to merge 4 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 13, 2024 •
edited
Loading

Bumps github.com/prometheus/client_golang from 1.18.0 to 1.19.1.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.19.1

What's Changed

  • Security patches for golang.org/x/sys and google.golang.org/protobuf

New Contributors

Full Changelog: prometheus/client_golang@v1.19.0...v1.19.1

v1.19.0

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

Unreleased

1.19.0 / 2023-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from renaynay as a code owner May 13, 2024 11:03
@dependabot dependabot bot added the kind:deps Pull requests that update a dependency file label May 13, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from 53e744b to 577f8c4 Compare May 13, 2024 13:47
walldiss
walldiss previously approved these changes May 13, 2024
View reviewed changes
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from 577f8c4 to e1184b9 Compare May 13, 2024 14:00
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from e1184b9 to ada39dd Compare May 27, 2024 13:44
@dependabot dependabot bot requested a review from cristaloleg as a code owner May 27, 2024 13:44
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from ada39dd to 48e7e4f Compare May 27, 2024 18:31
cristaloleg
cristaloleg previously approved these changes May 27, 2024
View reviewed changes
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch 2 times, most recently from 6bf2e8b to e9dd50e Compare May 28, 2024 09:36
@walldiss
Copy link
Member

@dependabot rebase

1 similar comment
@walldiss
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from e9dd50e to aa3638e Compare May 28, 2024 11:34
@walldiss
Copy link
Member

walldiss commented May 28, 2024 •
edited
Loading

Prometheus introduced breaking changes and this PR (client upgrade) is blocked by celestia-app, that uses pre-break client_golang version.
https://github.com/celestiaorg/celestia-app/blob/c4ae12cd786a82ce578b5df909aa281d2e7defd9/go.mod#L182

@dependabot dependabot bot dismissed stale reviews from walldiss and cristaloleg via 8aba928 June 3, 2024 06:19
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from aa3638e to 8aba928 Compare June 3, 2024 06:19
@dependabot
chore(deps): Bump github.com/prometheus/client_golang
f96e3a1 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.18.0...v1.19.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch from 8aba928 to f96e3a1 Compare June 3, 2024 12:33
cristaloleg
cristaloleg previously approved these changes Jun 3, 2024
View reviewed changes
ramin
ramin previously approved these changes Jun 4, 2024
View reviewed changes
@ramin ramin dismissed stale reviews from cristaloleg and themself via 8ed14eb June 5, 2024 09:34
@ramin ramin requested review from ramin, walldiss and cristaloleg June 5, 2024 09:35
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 19, 2024

A newer version of github.com/prometheus/client_golang exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@vgonkivs
Copy link
Member

Already bumped to 1.19.1

@vgonkivs vgonkivs closed this Aug 22, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.19.1 branch August 22, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@renaynay renaynay Awaiting requested review from renaynay

@Wondertan Wondertan Awaiting requested review from Wondertan

@vgonkivs vgonkivs Awaiting requested review from vgonkivs

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@walldiss walldiss Awaiting requested review from walldiss

@cristaloleg cristaloleg Awaiting requested review from cristaloleg

Assignees
No one assigned
Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@walldiss @vgonkivs @ramin @cristaloleg