testing(state/core_accessor): add async submitPFB test case #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
area:state
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss and
ramin
as code owners
ramin
approved these changes
May 10, 2024
walldiss
requested changes
May 10, 2024
walldiss
reviewed
May 10, 2024
Comment on lines
+97
to
+115
| hashCh := make(chan string) | ||
| for _, tc := range testcases { | ||
| if tc.asyncSubmission { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| go func() { | ||
| resp, err := ca.SubmitPayForBlob(ctx, tc.fee, tc.gasLim, tc.blobs) | ||
| if err == nil { | ||
| hashCh <- resp.TxHash | ||
| } | ||
| }() | ||
|
|
||
| ctx, cancel := context.WithTimeout(ctx, time.Second*3) | ||
| resp, err := ca.signer.ConfirmTx(ctx, <-hashCh) | ||
| cancel() | ||
| require.NoError(t, err) | ||
| require.EqualValues(t, 0, resp.Code) | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
If ca.SubmitPayForBlob returns non nill error, the test will hang forever because of deadlock on reading from <-hashCh and also no meaningful error will be logged or returned. To fix this lets do:
- use select with
ctx.Donefor reading from<-hashChso test can fail fast - use
reqiure.NoErrorfor error produced byca.SubmitPayForBlobto know what happen if it failed.
|
Moving to draft until the app provides an async version of SubmitPFB method. |
|
N/A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional test case checks whether tx was included in the block after async submission