chore(fmt/linters): Add gofumpt formatter and linter #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
ramin
as code owners
walldiss
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3331 +/- ##
==========================================
- Coverage 44.83% 44.74% -0.10%
==========================================
Files 265 273 +8
Lines 14620 15203 +583
==========================================
+ Hits 6555 6802 +247
- Misses 7313 7621 +308
- Partials 752 780 +28 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Apr 22, 2024
Wondertan
previously approved these changes
Apr 26, 2024
|
Actually there is a conflict |
Wondertan
approved these changes
Apr 26, 2024
vgonkivs
approved these changes
Apr 29, 2024
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
This PR enables stricter formatting by integrating `gofumpt`, which imposes more rules than the default gofmt, allowing for improved code formatting. The results, visible in this PR, include minor yet significant cleanups such as the removal of extra new lines and the consistent declaration of variables and constants.Integrating `gofumpt` will be a valuable addition to our code formatting automation, ensuring higher code quality and consistency.Additionally, the PR updates the Makefile and linter rules to include this enhanced formatting and applies it to the codebase. (cherry picked from commit e53e612)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
This PR enables stricter formatting by integrating `gofumpt`, which imposes more rules than the default gofmt, allowing for improved code formatting. The results, visible in this PR, include minor yet significant cleanups such as the removal of extra new lines and the consistent declaration of variables and constants.Integrating `gofumpt` will be a valuable addition to our code formatting automation, ensuring higher code quality and consistency.Additionally, the PR updates the Makefile and linter rules to include this enhanced formatting and applies it to the codebase. (cherry picked from commit e53e612)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables stricter formatting by integrating
gofumpt, which imposes more rules than the default gofmt, allowing for improved code formatting. The results, visible in this PR, include minor yet significant cleanups such as the removal of extra new lines and the consistent declaration of variables and constants.Integratinggofumptwill be a valuable addition to our code formatting automation, ensuring higher code quality and consistency.Additionally, the PR updates the Makefile and linter rules to include this enhanced formatting and applies it to the codebase.