refactor(share/sha-256): Consolidate SHA-256 Hash Function Usage #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kien6034
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
walldiss
reviewed
Apr 22, 2024
walldiss
previously approved these changes
Apr 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3330 +/- ##
==========================================
+ Coverage 44.83% 44.92% +0.08%
==========================================
Files 265 273 +8
Lines 14620 15204 +584
==========================================
+ Hits 6555 6830 +275
- Misses 7313 7597 +284
- Partials 752 777 +25 ☔ View full report in Codecov by Sentry. |
|
@walldiss hi, i've just resolved conflicts with the main branch, which dismissed your review. Can you please review this PR again? Thanks a lot |
walldiss
approved these changes
Apr 23, 2024
Wondertan
approved these changes
Apr 25, 2024
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
May 7, 2024
…estiaorg#3330) This PR consolidates SHA-256 hash function into the share/hashutils.go, and replaces all the sha256.New() functions with share.NewSHA256Hasher()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Closes #3275
Notes
This PR consolidates SHA-256 hash function into the
share/hashutils.go, and replaces all thesha256.New()functions withshare.NewSHA256Hasher()