-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/evm reader claim status #587
Conversation
47de075
to
f17dd2a
Compare
f17dd2a
to
851b817
Compare
851b817
to
25d491b
Compare
25d491b
to
e37c2e3
Compare
internal/evmreader/retrypolicy/retrypolicy_consensus_delegator.go
Outdated
Show resolved
Hide resolved
ecfa50d
to
e9b70be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor formatting details. Also, you need to squash the fixups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, split the changes into separate commits, specially because of the refactoring you did, @fmoura
0e09f60
to
a70988a
Compare
a70988a
to
00e7450
Compare
00e7450
to
43932d3
Compare
Code will be merged on temporary branch next/2.0 and refactored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as is with the intent of fixing the implementation later
No description provided.