Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm-reader): EVM Reader store only non empty epochs #578

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

fmoura
Copy link
Contributor

@fmoura fmoura commented Aug 26, 2024

No description provided.

@fmoura fmoura requested a review from a team August 26, 2024 20:22
@fmoura fmoura self-assigned this Aug 26, 2024
@fmoura fmoura force-pushed the feature/evm-reader-not-store-empty-epochs branch from 464825a to 499092c Compare August 26, 2024 21:11
Copy link
Collaborator

@vfusco vfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve this logic

@fmoura fmoura force-pushed the feature/evm-reader-not-store-empty-epochs branch from 499092c to 1eab387 Compare August 27, 2024 18:05
@fmoura fmoura requested review from vfusco and a team August 27, 2024 18:14
@fmoura fmoura added this to the 2.0.0 milestone Aug 27, 2024
@fmoura fmoura force-pushed the feature/evm-reader-not-store-empty-epochs branch from 1eab387 to 940bf64 Compare August 27, 2024 21:57
internal/repository/evmreader_test.go Outdated Show resolved Hide resolved
internal/repository/evmreader.go Show resolved Hide resolved
@fmoura fmoura requested a review from torives August 28, 2024 14:03
torives
torives previously approved these changes Aug 28, 2024
@marcelstanley marcelstanley added the no changelog PRs that don't require changes in changelog label Aug 28, 2024
@fmoura fmoura force-pushed the feature/evm-reader-not-store-empty-epochs branch 2 times, most recently from 6701812 to fd2e7b6 Compare August 28, 2024 18:58
@fmoura fmoura requested review from torives, a team and marcelstanley August 28, 2024 18:58
@fmoura fmoura force-pushed the feature/evm-reader-not-store-empty-epochs branch from fd2e7b6 to 8fa5dca Compare August 28, 2024 19:22
@fmoura fmoura merged commit 8fa5dca into next/2.0 Aug 29, 2024
6 checks passed
@fmoura fmoura deleted the feature/evm-reader-not-store-empty-epochs branch August 29, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs that don't require changes in changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants