Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update claimer to read from repository #499

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Update claimer to read from repository #499

merged 2 commits into from
Aug 28, 2024

Conversation

GMKrieger
Copy link
Contributor

@GMKrieger GMKrieger commented Jul 2, 2024 •
edited by marcelstanley
Loading

Closes #493

@GMKrieger GMKrieger added the #feat:claimer Feature: claimer label Jul 2, 2024
@GMKrieger GMKrieger added this to the 2.0.0 milestone Jul 2, 2024
@GMKrieger GMKrieger self-assigned this Jul 2, 2024
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch 3 times, most recently from d22057e to a893989 Compare July 2, 2024 18:42
@vfusco vfusco force-pushed the next/2.0 branch 2 times, most recently from a65d62d to d60173a Compare July 9, 2024 14:46
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch 5 times, most recently from 43a2295 to 34698b5 Compare July 17, 2024 22:20
@marcelstanley marcelstanley requested review from a team, renan061 and vfusco July 18, 2024 17:39
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch 2 times, most recently from afc6a45 to 87b837a Compare July 26, 2024 12:34
@marcelstanley
Copy link
Contributor

  • be63b95 could have its commit message changed to feat(claimer): use repository for managing claims
  • I also believe 87b837a should be a fixup for be63b95

@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch 4 times, most recently from ea80100 to 6867922 Compare August 20, 2024 23:51
@GMKrieger GMKrieger marked this pull request as ready for review August 20, 2024 23:52
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch 4 times, most recently from 3930ec1 to 98d3dfc Compare August 23, 2024 21:46
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch from 98d3dfc to ad424d0 Compare August 23, 2024 21:46
@marcelstanley marcelstanley requested review from a team and marcelstanley August 26, 2024 17:55
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch from ad424d0 to ea3c4f8 Compare August 27, 2024 19:15
marcelstanley
marcelstanley reviewed Aug 27, 2024
View reviewed changes
internal/node/services.go Show resolved Hide resolved
cmd/authority-claimer/src/repository.rs Show resolved Hide resolved
cmd/authority-claimer/src/claimer.rs Outdated Show resolved Hide resolved
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch from ea3c4f8 to 60f831b Compare August 27, 2024 22:17
@cartesi cartesi deleted a comment from GMKrieger Aug 27, 2024
@marcelstanley marcelstanley self-requested a review August 28, 2024 00:15
marcelstanley
marcelstanley previously approved these changes Aug 28, 2024
View reviewed changes
cmd/authority-claimer/src/claimer.rs Outdated Show resolved Hide resolved
torives
torives reviewed Aug 28, 2024
View reviewed changes
cmd/authority-claimer/src/repository.rs Outdated Show resolved Hide resolved
cmd/authority-claimer/src/repository.rs Outdated Show resolved Hide resolved
cmd/authority-claimer/src/sender.rs Show resolved Hide resolved
@GMKrieger GMKrieger force-pushed the feature/claimer-repository branch from 60f831b to 658078f Compare August 28, 2024 13:56
@GMKrieger GMKrieger merged commit 658078f into next/2.0 Aug 28, 2024
6 checks passed
@GMKrieger GMKrieger deleted the feature/claimer-repository branch August 28, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstanley marcelstanley marcelstanley approved these changes

@torives torives torives approved these changes

@renan061 renan061 Awaiting requested review from renan061

@vfusco vfusco Awaiting requested review from vfusco

Assignees

@GMKrieger GMKrieger

Labels
#feat:claimer Feature: claimer
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GMKrieger @marcelstanley @torives