Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3229] Move blockheader and block types to primitive lib #4246

Merged
merged 7 commits into from
Nov 20, 2023
Merged

[ADP-3229] Move blockheader and block types to primitive lib #4246

merged 7 commits into from
Nov 20, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Nov 18, 2023

Another primitive migration

  • Move BlockHeader, Block, PoolId, DelegationCertificate to primitive lib

@paolino paolino self-assigned this Nov 18, 2023
paweljakubas
paweljakubas approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from paolino/ADP-3229/move-slotting-parameters-to-primitive-lib to master November 20, 2023 09:57
@paolino paolino added this pull request to the merge queue Nov 20, 2023
@paolino paolino removed this pull request from the merge queue due to a manual request Nov 20, 2023
@paolino paolino enabled auto-merge November 20, 2023 11:02
@paolino paolino force-pushed the paolino/ADP-3229/move-blockheader-and-block-types-to-primitive-lib branch from 52285d7 to 3ccf046 Compare November 20, 2023 11:02
@paolino paolino force-pushed the paolino/ADP-3229/move-blockheader-and-block-types-to-primitive-lib branch from 3ccf046 to a318e1a Compare November 20, 2023 11:21
@paolino paolino added this pull request to the merge queue Nov 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2023
@paolino paolino added this pull request to the merge queue Nov 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2023
@paolino paolino added this pull request to the merge queue Nov 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2023
@paolino
[ADP-3229] Move stake pool summary to primitive lib (#4249)
29a688a 
More types migration

- [x] Move StakePoolSummary type to primitive lib

ADP-3229
@paolino paolino added this pull request to the merge queue Nov 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2023
@paolino paolino added this pull request to the merge queue Nov 20, 2023
Merged via the queue into master with commit dac1ff9 Nov 20, 2023
2 checks passed
@paolino paolino deleted the paolino/ADP-3229/move-blockheader-and-block-types-to-primitive-lib branch November 20, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @paweljakubas