Use Write.Tx type for tx field of PartialTx.
#4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
changed the base branch from
master
to
jonathanknowles/balance-tx-import-primitive-types
jonathanknowles
force-pushed
the
jonathanknowles/balance-tx-import-primitive-types
branch
from
082f6e2 to
fdc7401
Compare
jonathanknowles
commented
Nov 15, 2023
lib/balance-tx/lib/internal/Internal/Cardano/Write/Tx/Balance.hs
Outdated
Show resolved
Hide resolved
jonathanknowles
changed the title
Write.Tx type in tx field of PartialTx.Write.Tx type for tx field of PartialTx.
jonathanknowles
force-pushed
the
jonathanknowles/use-write-tx-in-partial-tx
branch
2 times, most recently
from
c41df08 to
8fb3856
Compare
jonathanknowles
force-pushed
the
jonathanknowles/use-write-tx-in-partial-tx
branch
from
8fb3856 to
f7e6359
Compare
jonathanknowles
force-pushed
the
jonathanknowles/use-write-tx-in-partial-tx
branch
from
f7e6359 to
90dc281
Compare
jonathanknowles
changed the base branch from
jonathanknowles/balance-tx-import-primitive-types
to
master
jonathanknowles
force-pushed
the
jonathanknowles/use-write-tx-in-partial-tx
branch
from
90dc281 to
590893f
Compare
Anviking
reviewed
Nov 15, 2023
| return $ PartialTx | ||
| (fromCardanoApiTx tx) | ||
| (fromCardanoApiUTxO inputUTxO) | ||
| (redeemers) |
There was a problem hiding this comment.
Suggested change
| (redeemers) | |
| redeemers |
Anviking
approved these changes
Nov 15, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Suggestion to #4235 - Fix compilation for GHC 9.2 - Replace `modifyLedgerBody` with ledger-api lens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ADP-3184
Description
This PR adjusts the
txfield ofPartialTxto use theWrite.Tx(ledger) type instead of the equivalent type fromcardano-api.Future work
Adjust
balanceTransactionto returnWrite.Tx(ledger) instead of the equivalent type fromcardano-api.