Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔮 Apply hlint suggestions from the future. #4172

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

jonathanknowles
Copy link
Contributor

@jonathanknowles jonathanknowles commented Oct 19, 2023

Issue

Related to #4171.

Description

This PR selectively applies suggestions from the latest version of hlint (3.6.1).

Motivation

This will make it easier to upgrade our build environment to use GHC version 9.2 or later, which will require us to upgrade to a newer version of hlint.

Our nix environment is currently only configured to use version 3.3 of hlint, which was released on2021-03-15. Note that we can't upgrade to a newer version of hlint without also upgrading GHC to at least version 9.2.

@jonathanknowles jonathanknowles self-assigned this Oct 19, 2023
@jonathanknowles jonathanknowles changed the title Apply hlint suggestions from the future. 🔮 Apply hlint suggestions from the future. Oct 19, 2023
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanknowles jonathanknowles added this pull request to the merge queue Oct 19, 2023
Merged via the queue into master with commit a884777 Oct 19, 2023
2 checks passed
@jonathanknowles jonathanknowles deleted the jonathanknowles/apply-hlint-suggestions branch October 19, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants