Move definition of txConstraints to cardano-wallet.
#4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function: - is not needed anywhere in `cardano-balance-tx`; - is only needed by the wallet's balance migration algorithm.
This value is already available in the scope of the outer function.
jonathanknowles
changed the title
txConstraints back to cardano-wallet.txConstraints to cardano-wallet.
These functions are not used anywhere in `cardano-balance-tx`.
Anviking
approved these changes
Oct 17, 2023
| @@ -36,10 +35,8 @@ module Cardano.Write.Tx.SizeEstimation | |||
|
|
|||
| -- * Needed for estimateSignedTxSize | |||
There was a problem hiding this comment.
The section title doesn't apply to the new sizeOf_VKeyWitnesses and sizeOf_Withdrawals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ADP-3185
Description
This PR moves the definition of function
txConstraintsback tocardano-wallet.The
txConstraintsfunction andTxConstraintstype:balanceTransaction);cardano-balance-txlibrary.So we can safely move the
txConstraintsfunction away fromcardano-balance-tx.This is consistent with our goal of minimising the public interface of
cardano-balance-tx.Notes
An alternative approach to this PR would be to move
txConstraintsto theInternalmodule hierarchy ofcardano-balance-tx, and then havecardano-walletdepend on theInternalmodule hierarchy. However, depending on an internal module seems unnecessary when we can just move this function to the only package that depends on it.