[ADP-3215] Remove fromCardanoApiTx from read (#4721)

This pull request removes the function `fromCardanoApiTx` from the `read` package, which in turn allows us to remove the dependency on `cardano-api`. The function `fromCardanoApiTx` is mainly used in the context of `SealedTx`, this pull request moves the function there. ### Issue Number ADP-3215
cardano-foundation · Aug 8, 2024 · 5970083 · 5970083
2 parents 17cc50f + a75e45b
commit 5970083
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 69 deletions.
diff --git a/cabal.project b/cabal.project
@@ -276,6 +276,9 @@ package cardano-wallet-read
 package cardano-wallet-text-class
   tests: True
 
+package cardano-wallet-unit
+  tests: True
+
 package cardano-numeric
   tests: True
 

diff --git a/lib/primitive/lib/Cardano/Wallet/Primitive/Ledger/Read/Tx/Sealed.hs b/lib/primitive/lib/Cardano/Wallet/Primitive/Ledger/Read/Tx/Sealed.hs
@@ -8,32 +8,42 @@
 
 module Cardano.Wallet.Primitive.Ledger.Read.Tx.Sealed
     ( fromSealedTx
-    , anythingFromSealedTx
     ) where
 
-import Prelude
-
 import Cardano.Api
     ( InAnyCardanoEra (..)
     )
-import Cardano.Read.Ledger.Tx.Cardano
-    ( fromCardanoApiTx
-    )
 import Cardano.Wallet.Primitive.Types.Tx.SealedTx
     ( SealedTx (unsafeCardanoTx)
     )
 import Cardano.Wallet.Read
-    ( EraValue
-    , Tx
-    , applyEraFun
+    ( EraValue (..)
+    , Tx (..)
+    )
+import Cardano.Wallet.Read.Eras
+    ( Allegra
+    , Alonzo
+    , Babbage
+    , Conway
+    , Mary
+    , Shelley
     )
 
+import qualified Cardano.Api as Cardano
+import qualified Cardano.Api.Shelley as Cardano
 import qualified Cardano.Wallet.Primitive.Types.Tx.SealedTx as W
 
 fromSealedTx:: W.SealedTx -> EraValue Tx
 fromSealedTx sealed =
     case unsafeCardanoTx sealed of
         InAnyCardanoEra _ce tx -> fromCardanoApiTx tx
 
-anythingFromSealedTx :: (forall era . Tx era -> a) -> SealedTx -> a
-anythingFromSealedTx f = applyEraFun f . fromSealedTx
+fromCardanoApiTx :: Cardano.Tx era -> EraValue Tx
+fromCardanoApiTx tx0 = case tx0 of
+    Cardano.ShelleyTx era tx -> case era of
+        Cardano.ShelleyBasedEraShelley -> EraValue (Tx tx :: Tx Shelley)
+        Cardano.ShelleyBasedEraAllegra -> EraValue (Tx tx :: Tx Allegra)
+        Cardano.ShelleyBasedEraMary -> EraValue (Tx tx :: Tx Mary)
+        Cardano.ShelleyBasedEraAlonzo -> EraValue (Tx tx :: Tx Alonzo)
+        Cardano.ShelleyBasedEraBabbage -> EraValue (Tx tx :: Tx Babbage)
+        Cardano.ShelleyBasedEraConway -> EraValue (Tx tx :: Tx Conway)
diff --git a/lib/read/cardano-wallet-read.cabal b/lib/read/cardano-wallet-read.cabal
@@ -55,7 +55,6 @@ library
     Cardano.Read.Ledger.Tx.Inputs
     Cardano.Read.Ledger.Tx.Outputs
     Cardano.Read.Ledger.Tx.TxId
-    Cardano.Read.Ledger.Tx.Cardano
     Cardano.Read.Ledger.Tx.Certificates
     Cardano.Read.Ledger.Tx.CBOR
     Cardano.Read.Ledger.Tx.CollateralInputs
@@ -106,7 +105,6 @@ library
   build-depends:
     , base
     , bytestring
-    , cardano-api
     , cardano-crypto
     , cardano-crypto-class
     , cardano-crypto-praos

diff --git a/lib/read/lib/Cardano/Read/Ledger/Tx/Cardano.hs b/lib/read/lib/Cardano/Read/Ledger/Tx/Cardano.hs
diff --git a/lib/unit/test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs b/lib/unit/test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs
@@ -57,9 +57,6 @@ import Cardano.Api.Gen
 import Cardano.Mnemonic
     ( SomeMnemonic (SomeMnemonic)
     )
-import Cardano.Read.Ledger.Tx.Cardano
-    ( fromCardanoApiTx
-    )
 import Cardano.Wallet
     ( Fee (..)
     , Percentile (..)
@@ -93,6 +90,9 @@ import Cardano.Wallet.Primitive.Ledger.Convert
 import Cardano.Wallet.Primitive.Ledger.Read.Tx.Features.Integrity
     ( txIntegrity
     )
+import Cardano.Wallet.Primitive.Ledger.Read.Tx.Sealed
+    ( fromSealedTx
+    )
 import Cardano.Wallet.Primitive.Ledger.Shelley
     ( toCardanoTxIn
     )
@@ -926,18 +926,14 @@ prop_signTransaction_preservesScriptIntegrity
                 Nothing
                 sealedTx
 
-            txIntegrityCardanoApi = txIntegrity . fromCardanoApiTx
-
-            getScriptIntegrityHashInAnyCardanoEra
-                :: InAnyCardanoEra Cardano.Tx
-                -> Maybe ByteString
-            getScriptIntegrityHashInAnyCardanoEra (InAnyCardanoEra _ tx') =
-                getHash <$> txIntegrityCardanoApi tx'
+            getScriptIntegrityHash :: SealedTx -> Maybe ByteString
+            getScriptIntegrityHash =
+                fmap getHash . txIntegrity . fromSealedTx
 
             scriptIntegrityHashBefore =
-                getScriptIntegrityHashInAnyCardanoEra $ cardanoTx sealedTx
+                getScriptIntegrityHash sealedTx
             scriptIntegrityHashAfter =
-                getScriptIntegrityHashInAnyCardanoEra $ cardanoTx sealedTx'
+                getScriptIntegrityHash sealedTx'
 
         checkCoverage
             $ cover 30 (isJust scriptIntegrityHashBefore)