more testing

cardano-foundation · Nov 16, 2023 · 3fabe93 · 3fabe93
1 parent 74b68f7
commit 3fabe93
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 14 deletions.
diff --git a/lib/wallet/test/unit/Cardano/Wallet/Api/TypesSpec.hs b/lib/wallet/test/unit/Cardano/Wallet/Api/TypesSpec.hs
@@ -822,6 +822,7 @@ spec = do
         jsonTest @WalletPutPassphraseData
         jsonTest @(ApiRewardAccount T0)
         jsonTest @(ApiExternalCertificate T0)
+        jsonTest @ApiVoteAction
 
     describe "ApiEra roundtrip" $
         it "toApiEra . fromApiEra == id" $ property $ \era -> do
@@ -2821,6 +2822,10 @@ instance ToSchema WalletPutPassphraseData where
     declareNamedSchema _ =
         declareSchemaForDefinition "ApiWalletPutPassphraseData"
 
+instance ToSchema ApiVoteAction where
+    declareNamedSchema _ =
+        declareSchemaForDefinition "ApiVoteAction"
+
 instance ToSchema ByronWalletPutPassphraseData where
     declareNamedSchema _ =
         declareSchemaForDefinition "ApiByronWalletPutPassphraseData"

diff --git a/specifications/api/swagger.yaml b/specifications/api/swagger.yaml
@@ -1401,19 +1401,6 @@ x-softIndex: &softIndex
   maximum: 2147483647
   description: A soft derivation index.
 
-x-transactionVote: &transactionVote
-  description: |
-    Voting action. One can abstain, give no confidence vote
-    or vote for a representative by specifying its key hash or script hash.
-    Voting can be done together with delegation action.
-  oneOf:
-    - type: string
-      enum:
-        - abstain
-        - no_confidence
-    - type: string
-      <<: *drep
-
 x-multiDelegationAction: &multiDelegationAction
   description: |
     A delegation action for a given stake key denoted by its soft index.
@@ -3720,6 +3707,19 @@ components:
             asset_name: *assetName
             operation: *ApiMintBurnOperation
 
+    ApiVoteAction: &ApiVoteAction
+      description: |
+        Voting action. One can abstain, give no confidence vote
+        or vote for a representative by specifying its key hash or script hash.
+        Voting can be done together with delegation action.
+      oneOf:
+        - type: string
+          enum:
+            - abstain
+            - no_confidence
+        - type: string
+          <<: *drep
+
     ApiConstructTransactionData: &ApiConstructTransactionData
       description: At least one field needs to be chosen
       type: object
@@ -3735,7 +3735,7 @@ components:
           description: |
              An entry for each unique asset to be minted and/or burned,
              containing helpful information.
-        vote: *transactionVote
+        vote: *ApiVoteAction
         delegations: *transactionDelegations
         validity_interval: *ApiValidityInterval
         reference_policy_script_template: