Skip to content

Commit

Permalink
Prune unused dependencies from cardano-wallet (#4270)
Browse files Browse the repository at this point in the history
## Issue

None. Noticed while attempting to clarify the dependency footprint of
one of our packages.

## Description

This PR removes **_some_** unused library dependencies from the
`cardano-wallet` project and its various packages.

## Future Work

Future PRs will:
 - remove all remaining unused library dependencies;
- adjust the cabal configuration so that unused dependencies cause a
build failure.
  • Loading branch information
jonathanknowles authored Nov 28, 2023
2 parents 3000c29 + e5a3d17 commit 388d80c
Show file tree
Hide file tree
Showing 15 changed files with 5 additions and 204 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ library
, cardano-ledger-shelley
, cardano-slotting
, cardano-wallet-primitive
, cardano-wallet-read
, cborg
, containers
, crypto-hash-extra
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,11 @@ library
hs-source-dirs: lib
build-depends:
, base ^>=4.14.3.0
, contra-tracer ^>=0.1.0.2
, iohk-monitoring ^>=0.1.11.3
, iohk-monitoring-extra ^>=0.1
, network ^>=3.1.4.0
, network-uri ^>=2.6.4.2
, optparse-applicative ^>=0.17.1
, random-shuffle ^>=0.0.4
, safe ^>=0.3.19
, streaming-commons ^>=0.2.2.6
, temporary ^>=1.3
, text ^>=1.2.4.1
, text-class ^>=2023.7.18
, unliftio ^>=0.2.24
Expand Down
5 changes: 2 additions & 3 deletions lib/balance-tx/cardano-balance-tx.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ library internal
, ouroboros-consensus-cardano
, pretty-simple
, QuickCheck
, random
, serialise
, std-gen-seed
, text
Expand Down Expand Up @@ -110,12 +109,12 @@ test-suite test
, bytestring
, cardano-api
, cardano-api-extra
, cardano-balance-tx:{cardano-balance-tx, internal}
, cardano-balance-tx:{internal}
, cardano-coin-selection
, cardano-ledger-alonzo-test
, cardano-ledger-api
, cardano-ledger-babbage:{cardano-ledger-babbage, testlib}
, cardano-ledger-conway:{cardano-ledger-conway, testlib}
, cardano-ledger-conway:{testlib}
, cardano-wallet-primitive
, cardano-wallet-test-utils
, containers
Expand Down
1 change: 0 additions & 1 deletion lib/coin-selection/cardano-coin-selection.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,4 @@ benchmark utxo-index
, format-numbers
, QuickCheck
, tasty-bench
, tasty-hunit
, text
8 changes: 0 additions & 8 deletions lib/delta-store/delta-store.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,11 @@ library
-Werror
build-depends:
base
, containers
, delta-types
, exceptions
, fmt
, io-classes
, mtl
, QuickCheck
, safe-exceptions
, semigroupoids
, stm
, text
, transformers
hs-source-dirs:
src
Expand All @@ -63,8 +57,6 @@ test-suite unit
ghc-options: -O2 -Werror
build-depends:
base
, io-classes
, io-sim
, hspec
, QuickCheck
, fmt
Expand Down
7 changes: 0 additions & 7 deletions lib/delta-table/delta-table.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,11 @@ library
, delta-store
, delta-types
, exceptions
, fmt
, generic-lens
, io-classes
, monad-logger
, persistent
, persistent-sqlite
, QuickCheck
, safe
, safe-exceptions
, say
, semigroupoids
, stm
Expand Down Expand Up @@ -72,10 +68,7 @@ test-suite unit
ghc-options: -O2 -Werror
build-depends:
base
, io-classes
, io-sim
, hspec
, QuickCheck
build-tool-depends:
hspec-discover:hspec-discover
type:
Expand Down
5 changes: 0 additions & 5 deletions lib/delta-types/delta-types.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ library
base
, containers
, fmt
, QuickCheck
, semigroupoids
, text
hs-source-dirs:
src
exposed-modules:
Expand All @@ -55,9 +53,6 @@ test-suite unit
build-depends:
base
, hspec
, QuickCheck
, fmt
, delta-types
build-tool-depends:
hspec-discover:hspec-discover
type:
Expand Down
1 change: 0 additions & 1 deletion lib/launcher/cardano-wallet-launcher.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ library
build-depends:
base
, bytestring
, code-page
, contra-tracer
, either
, extra
Expand Down
6 changes: 0 additions & 6 deletions lib/local-cluster/local-cluster.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ library
, aeson-qq ^>=0.8.4
, base
, base58-bytestring ^>=0.1
, bech32 ^>=1.1.2
, bech32-th
, binary ^>=0.8.8
, bytestring ^>=0.10.12
, cardano-addresses
, cardano-api
Expand All @@ -79,7 +76,6 @@ library
, containers ^>=0.6.5
, contra-tracer
, crypto-hash-extra ^>=0.1
, cryptonite ^>=0.30
, directory
, extra ^>=1.7
, filepath
Expand All @@ -88,9 +84,7 @@ library
, iohk-monitoring
, iohk-monitoring-extra
, lens ^>=5.1.1
, lobemo-backend-ekg
, memory ^>=0.18
, network-uri ^>=2.6.4.2
, OddWord ^>=1.0.1
, optparse-applicative
, ouroboros-network ^>=0.8.1
Expand Down
3 changes: 0 additions & 3 deletions lib/network-layer/cardano-wallet-network-layer.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,14 @@ library
, cardano-slotting
, cardano-wallet-launcher
, cardano-wallet-primitive
, cardano-wallet-read
, cborg
, containers
, contra-tracer
, exceptions
, fmt
, generics-sop
, io-classes
, iohk-monitoring
, iohk-monitoring-extra
, memory
, mtl
, network-mux
, nothunks
Expand Down
11 changes: 1 addition & 10 deletions lib/primitive/cardano-wallet-primitive.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -224,40 +224,31 @@ test-suite test
, cardano-addresses
, cardano-api
, cardano-crypto-class
, cardano-ledger-allegra:{cardano-ledger-allegra, testlib}
, cardano-ledger-byron-test
, cardano-ledger-allegra:{testlib}
, cardano-ledger-core:{cardano-ledger-core, testlib}
, cardano-ledger-shelley
, cardano-ledger-shelley-test
, cardano-numeric
, cardano-slotting
, cardano-wallet-primitive
, cardano-wallet-test-utils
, containers
, deepseq
, delta-store
, delta-types
, filepath
, fmt
, generic-arbitrary
, generic-lens
, hedgehog-quickcheck
, hspec
, hspec-core
, iohk-monitoring
, lattices
, lens
, MonadRandom
, ouroboros-consensus
, ouroboros-consensus-cardano
, ouroboros-network
, ouroboros-network-api
, QuickCheck
, quickcheck-classes
, quickcheck-instances
, quickcheck-monoid-subclasses
, quickcheck-quid
, should-not-typecheck
, string-qq
, text
, text-class
Expand Down
11 changes: 0 additions & 11 deletions lib/read/cardano-wallet-read.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -105,21 +105,16 @@ library
, cardano-ledger-alonzo-test
, cardano-ledger-api
, cardano-ledger-babbage
, cardano-ledger-babbage-test
, cardano-ledger-binary
, cardano-ledger-byron
, cardano-ledger-byron-test
, cardano-ledger-conway
, cardano-ledger-core
, cardano-ledger-mary
, cardano-ledger-shelley
, cardano-ledger-shelley-ma-test
, cardano-ledger-shelley-test
, cardano-protocol-tpraos
, cardano-strict-containers
, containers
, deepseq
, directory
, extra
, fmt
, generic-lens
Expand Down Expand Up @@ -157,13 +152,7 @@ test-suite test
, bytestring
, cardano-wallet-read
, cardano-wallet-test-utils
, casing
, extra
, formatting
, hspec
, memory
, OddWord
, QuickCheck
, text
, time
, with-utf8
1 change: 0 additions & 1 deletion lib/test-utils/cardano-wallet-test-utils.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ library
, file-embed
, formatting
, hspec
, directory
, either
, fmt
, generics-sop
Expand Down
5 changes: 0 additions & 5 deletions lib/wallet-benchmarks/cardano-wallet-benchmarks.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,12 @@ benchmark memory
build-depends:
, base
, cardano-wallet-launcher
, cardano-wallet-test-utils
, containers
, contra-tracer
, filepath
, fmt
, iohk-monitoring
, network
, process
, temporary
, text
, text-class
, transformers
, optparse-applicative
, with-utf8
Loading

0 comments on commit 388d80c

Please sign in to comment.