feat(client): allow tests to assign a fake requester #319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client test suite used by all client command tests fakes the
doer
today, which is a private internalRequester
implementation detail. Derived projects using the clientRequester
for extended commands needs to fake the Requester interface.This PR adds a client method
SetRequester(rw Requester)
to allow test code to fake the requester. This has to be public to allow an external package to fake this.Pending work remain to properly refactor the existing client test code to Fake the
Requester
instead of thedoer
. This is captured as an outstanding issue here: #315