-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snap): drive the snap release workflow to avoid skipping tagged versions #316
Conversation
38ccc1d
to
6666d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! I was hoping to see this before the next release. :-)
I haven't used snapcraft, but this looks good overall to me.
6666d50
to
5720ea6
Compare
I've added the credentials to the repo, disconnected from the snapcraft.io build service - I've just retriggered the CI to ensure that it passes before merging. |
It seems like the job is not picking up on the
|
No I think that's just because it doesn't include sensitive values in the log output :) I'm not sure what happened here, there is definitely a secret named |
When it's a secret GH will printout In this case, it didn't read anything. Can you check the repository's workflow permissions? |
Closing this PR in favour of #322 |
Fixes #300.
This PR addresses the issue described in #300. It includes the following changes:
remote-build
to drive the multi-arch builds,snapcraft.yaml
parts were updated in order to be supported by theremote-build
environment,push
,master
,edge
tocandidate
,Before merging
This has been tested in: https://github.com/cjdcordeiro/pebble/actions/runs/6505676433 and https://github.com/cjdcordeiro/pebble/actions/runs/6505679630