Dqlite v1.17.1 LTS, go-dqlite v2, Microcluster v2 & lxd, k8s-dqlite v1.3.0 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiseschmidtgen
force-pushed
the
KU-1965/dqlite-lts
branch
from
e510bbf to
5838fe1
Compare
HomayoonAlimohammadi
approved these changes
Nov 14, 2024
berkayoz
reviewed
Nov 14, 2024
bschimke95
requested changes
Nov 19, 2024
There was a problem hiding this comment.
This needs to wait and be updated once canonical/microcluster#290 is released (beginning of December).
This basically means we don't need microcluster v3 anymore but can pin the v2 LTS
louiseschmidtgen
changed the title
louiseschmidtgen
changed the title
louiseschmidtgen
changed the title
bschimke95
force-pushed
the
KU-1965/dqlite-lts
branch
from
5473dd5 to
9110a74
Compare
bschimke95
force-pushed
the
KU-1965/dqlite-lts
branch
from
9110a74 to
0e4cd5c
Compare
bschimke95
reviewed
Dec 5, 2024
bschimke95
reviewed
Dec 5, 2024
| @@ -31,8 +31,12 @@ func (e *Endpoints) postClusterBootstrap(_ state.State, r *http.Request) respons | |||
| } | |||
|
|
|||
| // Check if the cluster is already bootstrapped | |||
| _, err = e.provider.MicroCluster().Status(r.Context()) | |||
| if err == nil { | |||
| status, err := e.provider.MicroCluster().Status(r.Context()) | |||
There was a problem hiding this comment.
We had a bug in main here:
That version uses microcluster v3. This version contained a bug that was fixed in a later version
We silenced that issue here:
k8s-snap/src/k8s/pkg/k8sd/api/cluster_bootstrap.go
Lines 33 to 34 in 0e4cd5c
Instead of checking for the error we need to check for status.ready from that function.
Interestingly, this issue popped now up in v2 because the bugfix was backported with https://github.com/canonical/microcluster/pull/265/files and therefore no error was thrown anymore, causing the cluster falsely to claim that it is already bootstrapped.
There was a problem hiding this comment.
Great find @bschimke95! Thanks for resolving this bug.
bschimke95
reviewed
Dec 6, 2024
| @@ -23,8 +23,13 @@ func (e *Endpoints) postClusterJoin(s state.State, r *http.Request) response.Res | |||
| if err != nil { | |||
| return response.BadRequest(fmt.Errorf("invalid hostname %q: %w", req.Name, err)) | |||
| } | |||
| // Check if the cluster is already bootstrapped | |||
| status, err := e.provider.MicroCluster().Status(r.Context()) | |||
There was a problem hiding this comment.
louiseschmidtgen
commented
Dec 6, 2024
| @@ -31,8 +31,12 @@ func (e *Endpoints) postClusterBootstrap(_ state.State, r *http.Request) respons | |||
| } | |||
|
|
|||
| // Check if the cluster is already bootstrapped | |||
| _, err = e.provider.MicroCluster().Status(r.Context()) | |||
| if err == nil { | |||
| status, err := e.provider.MicroCluster().Status(r.Context()) | |||
There was a problem hiding this comment.
Great find @bschimke95! Thanks for resolving this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dqlite v1.17.1 LTS, go-dqlite v2, Microcluster v2 & lxd, k8s-dqlite v1.3.0
Use the new Dqlite LTS v1.17.1 and go-dqlite v2.
Microcluster v2 (LTS) will have a fix backported for us (joining issues with names by enabling us to add extra sans). Consequently, the lxd version is adjusted to support v2 of microcluster.
This PR updates the k8s-dqlite version from
v1.2.0tov1.3.0which uses Dqlite v1.17.1 LTS and go-dqlite v2.Release notes: https://github.com/canonical/k8s-dqlite/releases/tag/v1.3.0