Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Discourse 3.3.0 upgrade #278

Merged
merged 9 commits into from
Aug 21, 2024
Merged

feat: Discourse 3.3.0 upgrade #278

merged 9 commits into from
Aug 21, 2024

Conversation

alithethird
Copy link
Collaborator

@alithethird alithethird commented Aug 14, 2024

Updating to Discourse v3.3.0

Applicable spec: N/A

Overview

Upgrading the Discourse version from v3.2.0 to v.3.3.0
Added new part to install imagemagick from source because the used imagemagick is bumped to v7.1.1. Previously it was installed by apt and the version there is 6.9.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@alithethird alithethird changed the title Discourse 3 3 0 update feat: Discourse 3.3.0 upgrade Aug 15, 2024
@alithethird alithethird added enhancement New feature or request trivial labels Aug 15, 2024
@alithethird alithethird marked this pull request as ready for review August 15, 2024 09:32
@alithethird alithethird requested a review from a team as a code owner August 15, 2024 09:32
merkata
merkata previously approved these changes Aug 15, 2024
Copy link
Contributor

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, great work @alithethird ! I left two comments, they are about tidying up, so you can address them at a later point.

discourse_rock/patches/sigterm.patch Show resolved Hide resolved
discourse_rock/rockcraft.yaml Show resolved Hide resolved
nrobinaubertin
nrobinaubertin previously approved these changes Aug 19, 2024
Copy link
Contributor

Test coverage for 46f5963

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        371     41     94     15    88%   184, 192-193, 205, 337->345, 378->383, 395, 577-579, 584-585, 597-599, 604-605, 617-619, 642-644, 686->exit, 696->exit, 745-748, 758-759, 783-784, 796-797, 824-826, 828->833, 830-831, 873-874, 890-891, 901->exit, 915
src/database.py      29      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               400     42    102     16    88%

Static code analysis report

Run started:2024-08-19 14:15:39.012250

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2337
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link
Contributor

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alithethird alithethird merged commit 9ba8f6a into main Aug 21, 2024
19 checks passed
@alithethird alithethird deleted the discourse-3-3-0-update branch August 21, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants