-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISD-1516 Remove is_leader check when running db migration #189
Merged
Thanhphan1147
merged 5 commits into
main
from
remove_is_leader_check_when_running_db_migration
Feb 20, 2024
Merged
ISD-1516 Remove is_leader check when running db migration #189
Thanhphan1147
merged 5 commits into
main
from
remove_is_leader_check_when_running_db_migration
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanhphan1147
changed the title
Remove is_leader check when running db migration
ISD-1516 Remove is_leader check when running db migration
Feb 16, 2024
cbartz
previously approved these changes
Feb 19, 2024
mthaddon
reviewed
Feb 19, 2024
…thub.com:canonical/discourse-k8s-operator into remove_is_leader_check_when_running_db_migration
Test coverage for cf63c26
Static code analysis report
|
nrobinaubertin
approved these changes
Feb 19, 2024
mthaddon
approved these changes
Feb 20, 2024
Thanhphan1147
deleted the
remove_is_leader_check_when_running_db_migration
branch
February 20, 2024 11:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can take advantage of the idem-potency of the
db:migrate
task to remove a check and run that task on all units.Local tests shows a time loss of around 3s per unit for each skipped checks (note that unit-discourse-k8s-1 is doing the actual migration and the other calling the task and skipping it):
Checklist
src-docs
urgent
,trivial
,complex
)