cicd: use ruff for autoformatting #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
requested review from
korikuzma
and removed request for
korikuzma
korikuzma
previously approved these changes
Nov 10, 2023
.github/workflows/github-actions.yml
Outdated
| - name: ruff | ||
| uses: chartboost/ruff-action@v1 | ||
| - name: Check style | ||
| run: python3 -m ruff check src/ tests/ && python3 -m ruff format --check src/ tests/ |
There was a problem hiding this comment.
Suggested change
| run: python3 -m ruff check src/ tests/ && python3 -m ruff format --check src/ tests/ | |
| run: python3 -m ruff check . && python3 -m ruff format --check . |
There was a problem hiding this comment.
@korikuzma this means that docs/conf.py gets checked/formatted, which I think is undesired -- it's a bit easier to manage manually (formatting also makes it look a little weird)
There was a problem hiding this comment.
Ah gotcha, we could also exclude docs/conf.py in pyproject.toml
korikuzma
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was limited in what I could work on on the plane, so I hit some low hanging fruit