Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jsstevenson committed Dec 12, 2023
1 parent d31a7cf commit 6606087
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
8 changes: 3 additions & 5 deletions src/gene/etl/ncbi.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,9 @@ def _extract_data(self, use_existing: bool) -> None:
) # type: ignore
self._info_src = gene_paths.gene_info
self._history_src = gene_paths.gene_history
self._gene_url = (
"ftp.ncbi.nlm.nih.govgene/DATA/GENE_INFO/Mammalia/Homo_sapiens.gene_info.gz"
)
self._history_url = "ftp.ncbi.nlm.nih.govgene/DATA/gene_history.gz"
self._assembly_url = "ftp.ncbi.nlm.nih.govgenomes/refseq/vertebrate_mammalian/Homo_sapiens/latest_assembly_versions/"
self._gene_url = "ftp.ncbi.nlm.nih.gov/gene/DATA/GENE_INFO/Mammalia/Homo_sapiens.gene_info.gz"
self._history_url = "ftp.ncbi.nlm.nih.gov/gene/DATA/gene_history.gz"
self._assembly_url = "ftp.ncbi.nlm.nih.gov/genomes/refseq/vertebrate_mammalian/Homo_sapiens/latest_assembly_versions/"

def _get_prev_symbols(self) -> Dict[str, str]:
"""Store a gene's symbol history.
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/test_ncbi_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -575,9 +575,9 @@ def spg37():
def source_urls():
"""Provide source data URLs fixture."""
return {
"info_file": "ftp.ncbi.nlm.nih.govgene/DATA/GENE_INFO/Mammalia/Homo_sapiens.gene_info.gz",
"history_file": "ftp.ncbi.nlm.nih.govgene/DATA/gene_history.gz",
"assembly_file": "ftp.ncbi.nlm.nih.govgenomes/refseq/vertebrate_mammalian/Homo_sapiens/latest_assembly_versions/",
"info_file": "ftp.ncbi.nlm.nih.gov/gene/DATA/GENE_INFO/Mammalia/Homo_sapiens.gene_info.gz",
"history_file": "ftp.ncbi.nlm.nih.gov/gene/DATA/gene_history.gz",
"assembly_file": "ftp.ncbi.nlm.nih.gov/genomes/refseq/vertebrate_mammalian/Homo_sapiens/latest_assembly_versions/",
}


Expand Down

0 comments on commit 6606087

Please sign in to comment.