Updating dependencies

README.md

@@ -1,12 +1,9 @@
-# node-red-contrib-zeebe
+# node-red-contrib-zeebe-2 (fork of node-red-contrib-zeebe, updated to zeebe-node 8.2.x)
+### (Work in progress)
 
-[![](https://img.shields.io/badge/Community%20Extension-An%20open%20source%20community%20maintained%20project-FF4700)](https://github.com/camunda-community-hub/community)
+![Compatible with: Camunda Platform 8.2+](https://img.shields.io/badge/Compatible%20with-Camunda%20Platform%208-0072Ce)
 
-[![](https://img.shields.io/badge/Lifecycle-Incubating-blue)](https://github.com/Camunda-Community-Hub/community/blob/main/extension-lifecycle.md#incubating-)
-
-![Compatible with: Camunda Platform 8](https://img.shields.io/badge/Compatible%20with-Camunda%20Platform%208-0072Ce)
-
-![npm](https://img.shields.io/npm/v/node-red-contrib-zeebe)
+![npm](https://img.shields.io/npm/v/node-red-contrib-zeebe-2)
 
 This module leverages the [zeebe-node](https://creditsenseau.github.io/zeebe-client-node-js/index.html) client library to bring Zeebe awesomeness to Node-RED!
 
@@ -99,7 +96,3 @@ And then run them manually:
 ```bash
 npm run test:integration
 ```
-
-## Contributions
-
-Contributions are always welcome! There are some [open issues](https://github.com/camunda-community-hub/node-red-contrib-zeebe/issues).

__mocks__/zeebe-node.js

@@ -1,27 +1,24 @@
-const mockJob = { key: '111', variables: {} };
-const mockComplete = {
-    success: jest.fn(),
-    failure: jest.fn(),
+const mockJob = { key: '111', variables: {} ,
+    complete: jest.fn(),
+    fail: jest.fn(),
     error: jest.fn(),
+    forward: jest.fn(),
 };
 
 exports.ZBClient = jest.fn().mockImplementation(() => {
     return {
-        createWorker: (
-            workerName,
+        createWorker: ({
             taskType,
-            handler,
-            workerOptions,
-            onConnectionError
-        ) => {
+            taskHandler,
+            ...workerOptions
+        }) => {
             // call the handler asynchronously right after ZBClient has been created
-            setTimeout(() => handler(mockJob, mockComplete));
+            setTimeout(() => taskHandler(mockJob));
         },
         publishMessage: jest.fn(),
         publishStartMessage: jest.fn(),
-        deployWorkflow: jest.fn().mockResolvedValue({
-            workflows: [{ bpmnProcessId: 'my-process' }],
-        }),
+        deployResource: jest.fn().mockResolvedValue({ bpmnProcessId: 'my-process' }),
+
         createProcessInstance: jest.fn(),
         close: () => {},
     };

__tests__/complete-task_spec.js

@@ -3,15 +3,16 @@ const completeTaskNode = require('../src/nodes/complete-task.js');
 
 helper.init(require.resolve('node-red'));
 
-const completeMock = {
-    success: jest.fn(),
-    failure: jest.fn(),
+const jobMock = {
+    complete: jest.fn(),
+    fail: jest.fn(),
     error: jest.fn(),
+    variables: { workflowId: 123 }
 };
 
 describe('complete-task node', () => {
     beforeEach((done) => {
-        helper.startServer(done);
+         helper.startServer(done);
         jest.resetAllMocks();
     });
 
@@ -20,9 +21,7 @@ describe('complete-task node', () => {
         helper.stopServer(done);
     });
 
-    it('should call complete.success with variables', (done) => {
-        const variables = { workflowId: 123 };
-
+    it('should call job.complete with variables', (done) => {
         var flow = [
             {
                 id: 'n1',
@@ -33,17 +32,17 @@ describe('complete-task node', () => {
 
         helper.load([completeTaskNode], flow, () => {
             const n1 = helper.getNode('n1');
-
-            completeMock.success.mockImplementation(() => {
-                expect(completeMock.success).toHaveBeenCalledTimes(1);
-                expect(completeMock.success).toHaveBeenCalledWith(variables);
+            jobMock.complete.mockImplementation(() => {
+                expect(jobMock.complete).toHaveBeenCalledTimes(1);
+                expect(jobMock.complete).toHaveBeenCalledWith(jobMock.variables);
                 done();
             });
 
             n1.receive({
                 payload: {
-                    complete: completeMock,
-                    variables,
+                    job: jobMock,
+                    variables: jobMock.variables,
+
                 },
             });
         });
@@ -63,17 +62,17 @@ describe('complete-task node', () => {
 
             const n1 = helper.getNode('n1');
 
-            completeMock.failure.mockImplementation(() => {
-                expect(completeMock.failure).toHaveBeenCalledTimes(1);
-                expect(completeMock.failure).toHaveBeenCalledWith(
+            jobMock.fail.mockImplementation(() => {
+                expect(jobMock.fail).toHaveBeenCalledTimes(1);
+                expect(jobMock.fail).toHaveBeenCalledWith(
                     failureMessage
                 );
                 done();
             });
 
             n1.receive({
                 payload: {
-                    complete: completeMock,
+                    job: jobMock,
                     type: 'failure',
                     failureMessage,
                 },
@@ -96,21 +95,25 @@ describe('complete-task node', () => {
 
             const n1 = helper.getNode('n1');
 
-            completeMock.error.mockImplementation(() => {
-                expect(completeMock.error).toHaveBeenCalledTimes(1);
-                expect(completeMock.error).toHaveBeenCalledWith(
-                    errorCode,
-                    errorMessage
+            jobMock.error.mockImplementation(() => {
+                expect(jobMock.error).toHaveBeenCalledTimes(1);
+                expect(jobMock.error).toHaveBeenCalledWith(
+                    {
+                        errorCode,
+                        errorMessage,
+                        variables: jobMock.variables,
+                    }
                 );
                 done();
             });
 
             n1.receive({
                 payload: {
-                    complete: completeMock,
+                    job: jobMock,
                     type: 'error',
                     errorCode,
                     errorMessage,
+                    variables: jobMock.variables,
                 },
             });
         });

__tests__/deploy_spec.js

@@ -15,7 +15,7 @@ describe('deploy node', () => {
         helper.stopServer(done);
     });
 
-    it('should call zbc.deployWorkflow', (done) => {
+    it('should call zbc.deployResource', (done) => {
         var flow = [
             {
                 id: 'n1',
@@ -42,22 +42,21 @@ describe('deploy node', () => {
 
             n3.on('input', (msg) => {
                 Promise.resolve().then(() => {
-                    expect(n1.zbc.deployWorkflow).toHaveBeenCalledTimes(1);
-                    expect(n1.zbc.deployWorkflow).toHaveBeenCalledWith(
+                    expect(n1.zbc.deployResource).toHaveBeenCalledTimes(1);
+                    expect(n1.zbc.deployResource).toHaveBeenCalledWith(
                         expect.objectContaining({
                             name: expect.stringMatching(/^test.bpmn$/),
-                            definition: expect.any(Buffer),
+                            process: expect.any(Buffer),
                         })
                     );
-                    expect(msg.payload).toEqual({
-                        workflows: [{ bpmnProcessId: 'my-process' }],
-                    });
+                    expect(msg.payload.bpmnProcessId).toEqual('my-process' )
                     done();
                 });
             });
 
             n2.receive({
                 payload: {
+                    resourceType: 'process',
                     definition: '<xml />',
                     resourceName: 'test.bpmn',
                 },

__tests__/task-worker_spec.js

@@ -4,7 +4,7 @@ const zeebeNode = require('../src/nodes/zeebe');
 
 helper.init(require.resolve('node-red'));
 
-describe('task-worder node', () => {
+describe('task-worker node', () => {
     beforeEach((done) => {
         helper.startServer(done);
     });
@@ -14,7 +14,7 @@ describe('task-worder node', () => {
         helper.stopServer(done);
     });
 
-    it('should ouput response from zebee-node', (done) => {
+    it('should output response from zeebe-node', (done) => {
         var flow = [
             {
                 id: 'n1',
@@ -37,9 +37,9 @@ describe('task-worder node', () => {
 
             n3.on('input', (msg) => {
                 Promise.resolve().then(() => {
-                    expect(msg.payload.complete.success).toBeDefined();
-                    expect(msg.payload.complete.failure).toBeDefined();
-                    expect(msg.payload.job).toBeDefined();
+                    expect(msg.payload.job.complete).toBeDefined();
+                    expect(msg.payload.job.fail).toBeDefined();
+                    expect(msg.payload.job.error).toBeDefined();
                     done();
                 });
             });