feat: migrate twitter example to Camunda Spring SDK #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megglos
commented
Dec 30, 2024
...ringboot/src/main/java/org/camunda/community/examples/twitter/TwitterExampleApplication.java
Show resolved
Hide resolved
megglos
commented
Dec 30, 2024
| @@ -18,7 +21,7 @@ public void handleTweet(@VariablesAsType TwitterProcessVariables variables) thro | |||
| try { | |||
| twitterService.tweet(variables.getTweet()); | |||
| } catch (DuplicateTweetException ex) { | |||
| throw new ZeebeBpmnError("duplicateMessage", "Could not post tweet, it is a duplicate."); | |||
| throw new ZeebeBpmnError("duplicateMessage", "Could not post tweet, it is a duplicate.", Map.of()); | |||
There was a problem hiding this comment.
UX flaw that we lack a compatible ctor, will follow-up with the team.
megglos
commented
Dec 30, 2024
7 tasks
megglos
force-pushed
the
meg-26429-migration-to-spring-sdk
branch
2 times, most recently
from
9a600c2 to
c1680dd
Compare
megglos
force-pushed
the
meg-26429-migration-to-spring-sdk
branch
from
c1680dd to
2880f5a
Compare
megglos
force-pushed
the
meg-26429-migration-to-spring-sdk
branch
from
2880f5a to
7c70148
Compare
megglos
commented
Jan 7, 2025
| <spring-boot.version>3.3.0</spring-boot.version> | ||
| <zeebe.version>8.5.10</zeebe.version> | ||
| <spring-zeebe.version>8.5.7</spring-zeebe.version> | ||
| <spring-boot.version>3.3.7</spring-boot.version> |
There was a problem hiding this comment.
aligned with the version used by the sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the twitter sample referenced in the Development docs to make use of the offical SDK + the sdk testing module (fork from former community sdk) released with the 8.6.7 patch.
Closes camunda/camunda#26429
Additional context
Types of changes
Checklist:
.github/workflows/build.yaml