Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up test directory, and initial add form management tests #89

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

PascalinDe
Copy link
Member

This PR includes some clean up of the test directory, adds form management tests and resolves the UI part of #81

@PascalinDe PascalinDe requested a review from ineiti January 25, 2024 08:38
Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change from evoting to forms, but some of the elements are still evoting. Is it worth changing them to forms, too? Instead of

  • json/evoting/{dkgActors,forms}
  • json/{dkgActors,forms}

Edit: OK, doesn't make sense, as it follows the api-paths.

web/frontend/tests/mocks/evoting.ts Outdated Show resolved Hide resolved
web/frontend/tests/mocks/evoting.ts Outdated Show resolved Hide resolved
web/frontend/tests/mocks/evoting.ts Show resolved Hide resolved
@PascalinDe
Copy link
Member Author

I like the change from evoting to forms, but some of the elements are still evoting. Is it worth changing them to forms, too? Instead of

* json/evoting/{dkgActors,forms}

* json/{dkgActors,forms}

the json directory is following the API, so the documents for /evoting/whatever are in json/evoting, the documents for /api/* are in json/api

@PascalinDe PascalinDe requested a review from ineiti January 25, 2024 13:10
@PascalinDe PascalinDe merged commit a2a262a into main Jan 25, 2024
11 checks passed
@PascalinDe PascalinDe deleted the 72 branch January 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants