Fix the voting-benchmark test #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
voting_benchmark
branch
from
a4c7a6c to
82b8bf3
Compare
ineiti
force-pushed
the
voting_benchmark
branch
5 times, most recently
from
979a825 to
38ea046
Compare
PascalinDe
reviewed
Jan 25, 2024
integration/integration_test.go
Outdated
| @@ -293,6 +293,7 @@ func getIntegrationTestCrash(numNodes, numVotes, failingNodes int) func(*testing | |||
| form, err = getForm(formFac, formID, nodes[0].GetOrdering()) | |||
| t.Logf("PubsharesUnit: %v", form.PubsharesUnits) | |||
| require.NoError(t, err) | |||
| // LG@240124: had some fuzzy failures when decrypting the ballots here. | |||
There was a problem hiding this comment.
can you please add a ticket w/ this comment and some details?
There was a problem hiding this comment.
Added #90 and referenced it here and in line 288.
PascalinDe
reviewed
Jan 25, 2024
| @@ -114,9 +115,12 @@ func (m txManager) addAndWait(args ...txn.Arg) ([]byte, error) { | |||
|
|
|||
| err = m.n.GetPool().Add(sentTxn) | |||
| if err != nil { | |||
| return nil, xerrors.Errorf("failed to Add: %v", err) | |||
| fmt.Printf("Failed to add transaction: %v", err) | |||
| continue | |||
There was a problem hiding this comment.
that's indeed odd that an retry-loop failed on the first error, I guess it makes your sense with your change
There was a problem hiding this comment.
Even the more so that one of the errors is the famous "wrong nonce" error, which happens quite often and needs a new transaction to be created...
This PR follows updates to Dela to make the benchmark test run again.
ineiti
force-pushed
the
voting_benchmark
branch
from
38ea046 to
107a297
Compare
PascalinDe
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows updates to Dela to make the voting benchmark run again.