Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed status bar not displaying termination UI #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed status bar not displaying termination UI #92

wants to merge 1 commit into from

Conversation

qub1750ul
Copy link

Fixes #91
I'm not a web-tech guy, i don't know neither javascript nor coffeescript, literally don't know what i'm doing.
But it works.

Fixes #91 
I'm not a web-tech guy, i don't know neither javascript nor coffeescript, literally don't know what i'm doing.
But it works.
@@ -15,9 +15,9 @@ class StatusBar extends View
returnFocus: null

@content: ->
@div class: 'termination status-bar', tabindex: -1, =>
@div class: 'termination inline-block', tabindex: -1, =>
Copy link
Member

@the-j0k3r the-j0k3r Nov 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no actual less/CSS class inline-block defined, so technically this is breaking something, it would probably work by removing it you can test this easily if by removing it would also fix issue.

removing

&.status-bar {
really needs to be considered.

If removing it ( just leave termination in these changes) fixes the issue, then it probably means this should be fixed some other way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-j0k3r @qub1750ul sorry I'll check this soon

@the-j0k3r
Copy link
Member

@Fred-Barclay @qub1750ul

What you may want todo is try this

display: -webkit-flex;

and remove the -webkit-flex replacing it with a non vendor prefix CSS alternative like display: flex or display: inline block and revert the proposed change which is actually 100% incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Disabling "Clone Terminal-Plus" disables the termination UI
3 participants