Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto#secureCompare : use the primitive type as the return value could not be null #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Crypto#secureCompare : use the primitive type as the return value could not be null #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 3.3.1
* Fix Crypto#secureCompare to use the primitive type as the return value could not be null

## 3.3.0
* Add `acquirerReferenceNumber` to `Transaction`
* Add `billingAgreementId` to `PayPalDetails`
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/braintreegateway/util/Crypto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.braintreegateway.util;

public class Crypto {
public Boolean secureCompare(String left, String right) {
public boolean secureCompare(String left, String right) {
if (left == null || right == null || (left.length() != right.length())) {
return false;
}
Expand Down