Shopper insights rp2 feature #1502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `isPayPalAppInstalled`, `isVenmoAppInstalled` methods * Moved methods to Shopper Insights * Fixed failing unit tests. Added to CHANGELOG * Addressed PR comment * Update Sources/BraintreeShopperInsights/BTShopperInsightsClient.swift
* Added `sessionID` to BTShopperInsightClient. Added unit tests * Added unit tests. Updated demo app * Added to CHANGELOG * Removed `payPalSessionID`
* Add shopperSessionID to BTPayPalRequest * Update parameters to Vault and Checkout request * Testing shopperSessionId * Demo app textField for shopper session Id * Added unit test * Updated CHANGELOG * Fixed lint error * Remove UI for demo app and adding shopper sessionId property to native checkout and web checkout. * Update comment for shopper session Id * Fixed lint errors * PR update --------- Co-authored-by: stechiu <stechiu@paypal.com>
#1482) * If a shopperSessionID exists, override the value with the one retrieved from Shopper Insights Server * Add unit tests * Update unit tests
…o shopper-insights-rp1-feature # Conflicts: # CHANGELOG.md # Sources/BraintreePayPal/BTPayPalClient.swift
* Changelog * Fix merge conflict * update invokedOpenURLSuccessfully with main * update CHANGELOG from merge confict --------- Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
…ted Events (#1484) * Added presentment details and events * Addressed PR comments * Added doc strings * Updated CHANGELOG and unit tests * Addressed PR comments * Addressed PR comments * Fixed failing tests * Removed test from bad merge * Fixed failing unit test * Added unit tests * Added missing unit tests * Updated `buttonOrder` and doc strings * Removed `experimentType` * Updated doc strings * Fixed failing tests * Remove experimentType * Create functions to toggle the paypal or venmo buttons and send presentment analytics at the correct time. * Update docs * Re add functions that were deleted. Chnage accessor for func used in unit test * Reverse changes to PayPalClient * Remove trailing white space * Update Sources/BraintreeShopperInsights/BTPresentmentDetails.swift * Update * Update CHANGELOG.md --------- Co-authored-by: Justin Warmkessel <Jwarmkessel@paypal.com> Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
* Added BTButtonType enum and `sendSelectedEvent()` * Updated unit tests * Addressed PR comments * Fixed failing unit test * Removed unnecessary unit tests * add parameters to docstring for presented event --------- Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
…o shopper-insights-rp1-feature # Conflicts: # CHANGELOG.md
| @@ -0,0 +1,25 @@ | |||
| import Foundation | |||
|
|
|||
| public class BTPresentmentDetails { | |||
There was a problem hiding this comment.
Can we add a docstring and beta warning here?
| public func sendVenmoPresentedEvent(paymentMethodsDisplayed: [String?] = [], experiment: String? = nil) { | ||
| let paymentMethodsDisplayedString = paymentMethodsDisplayed.compactMap { $0 }.joined(separator: ", ") | ||
| /// - Parameter buttonType: Type of button presented - PayPal, Venmo, or Other | ||
| public func sendSelectedEvent(for buttonType: BTButtonType) { |
There was a problem hiding this comment.
Can we add our beta warning here?
| /// - Parameter apiClient: A `BTAPIClient` instance. | ||
| /// - Parameters: | ||
| /// - apiClient: A `BTAPIClient` instance. | ||
| /// - shopperSessionID: This value should be the shopper session ID returned from your server SDK request | ||
| /// - Warning: This features only works with a client token. |
There was a problem hiding this comment.
Lets also add a warning that this init is beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Merge ShopperInsights Feature RP2 to main. Updated from main -> rp1 -> rp2.
Checklist
Authors
@warmkesselj
@jwarmkessel