Venmo - Support App Link Returns

[scannillo]

Epic: DTMOBILES-927
Jira: DTMOBILES-1163

Summary of changes

• Enable merchants to pass a appLinkReturnUri to VenmoClient
• Deprecate returnUrlScheme integration pattern

⚠️ Pending RCIP approval from Venmo side before merge & release.

Checklist

• Added a changelog entry
• Relevant test coverage

Authors

@scannillo

[scannillo]

RCIP case 3021997 has been closed. This PR is ready for merge / release.

[sarahkoop]

Not blocking this PR but wanted to note for @saperi22 and @tdchow we will likely need to add the same fallback support from #1223 for Venmo too as a fast follow. Can you double check and confirm the approach in both PRs is still good for Venmo?

[tdchow]

Not blocking this PR but wanted to note for @saperi22 and @tdchow we will likely need to add the same fallback support from #1223 for Venmo too as a fast follow. Can you double check and confirm the approach in both PRs is still good for Venmo?

I had the same thought 😄 I looked through this PR again and we should be able to reuse the same use case and fallback URL scheme param for the Venmo integration.

[scannillo]

Hey @tdchow - thanks for the callout on the deeplink fallback case. Should we hold on merging this until that work is complete? Do we have a JIRA # for it?

I can always put this into a temp feature branch instead of leaving this PR open

[tdchow]

Hey @tdchow - thanks for the callout on the deeplink fallback case. Should we hold on merging this until that work is complete? Do we have a JIRA # for it?

I can always put this into a temp feature branch instead of leaving this PR open

We could either merge this PR in and I'll have a fast follow PR for adding deep link support. Or we can create a temp feature branch we can merge both changes to and then merge that into main. I'm good either way!

[scannillo]

We could either merge this PR in and I'll have a fast follow PR for adding deep link support. Or we can create a temp feature branch we can merge both changes to and then merge that into main. I'm good either way!

Merged! Thanks for confirming, Tim

[scannillo]

Hey @tdchow and @saperi22, I was thinking about this a bit more. Based on this PR, would we want to make a returnURLScheme required if a merchant opts to use an appLink (for this new constructor)? Essentially, if they use app links they also need to pass the returnURLScheme. Should this be our future direction?

[tdchow]

Hi @scannillo - I believe we wanted to have the deep link fallback as an opt-in for merchants. I can see some merchants only wanting to only implement app links due to the additional security that app links provide over deep links. For the PayPal integration, merchants are now required to use app links for their integration, so that's why we kept the deep link scheme as optional. Happy to discuss if this should not be the case!

[scannillo]

Makes sense to me!